[jira] Resolved: (BEEHIVE-306) Rename tree image icons for clarity

["Daryl Olander (JIRA)" <be...@incubator.apache.org>]

     [ http://issues.apache.org/jira/browse/BEEHIVE-306?page=history ]
     
Daryl Olander resolved BEEHIVE-306:
-----------------------------------

    Resolution: Fixed

This bug was fixed with Jira 320.  Basically both bugs are about renaming the publically exposed attribute on the tree to rationalize their names.  

Revision: 154333

This is the list of all the changes:

Tree
The following JSP attribute names where changed on the tree tag:
imageHandleDownLast -> lastNodeExpandedImage
imageHandleDownMiddle -> nodeExpandedImage
imageHandleRightLast -> lastNodeCollapsedImage
imageHandleRightMiddle -> nodeCollapsedImage
imageLineLast -> lastLineJoinImage
imageLineMiddle -> lineJoinImage
imageLineVertical -> verticalLineImage
defaultIcon -> itemIcon
renderJavaScript -> renderTagIdLookup
selectionStyle ->selectedStyle
selectionClass -> selectedStyleClass
unselectStyle -> unselectedStyle
unselectClass -> unselectedStyleClass
treeClass -> treeStyleClass
disableClass ->disabledStyleClass

TreePropertyOverride tag
The following JSP attribute changes where made:
imageHandleDownLast -> lastNodeExpandedImage
imageHandleDownMiddle -> nodeExpandedImage
imageHandleRightLast -> lastNodeCollapsedImage
imageHandleRightMiddle -> nodeCollapsedImage
imageLineLast -> lastLineJoinImage
imageLineMiddle -> lineJoinImage
imageLineVertical -> verticalLineImage
defaultIcon -> itemIcon

TreeRenderState
The following fields where changed in this class:
selectionStyle -> selectedStyle
selectionClass -> selectedStyleClass
unselectStyle -> unselectedStyle
unselectClass -> unselectedStyleClass
disabledStyle -> disabledStyle  (unchanged)
disabledClass -> disabledStyleClass

InheritableStatte
The following property changes (set/get) were made to this class:
imageHandleDownLast -> lastNodeExpandedImage
imageHandleDownMiddle -> nodeExpandedImage
imageHandleRightLast -> lastNodeCollapsedImage
imageHandleRightMiddle -> nodeCollapsedImage
imageLineLast -> lastLineJoinImage
imageLineMiddle -> lineJoinImage
imageLineVertical -> verticalLineImage


> Rename tree image icons  for clarity
> ------------------------------------
>
>          Key: BEEHIVE-306
>          URL: http://issues.apache.org/jira/browse/BEEHIVE-306
>      Project: Beehive
>         Type: Improvement
>   Components: NetUI
>     Versions: V1
>     Reporter: John Rohrlich
>     Assignee: Daryl Olander
>     Priority: Minor

>
> Renaming the tree images would help clarify the use of each image
> I suggest the following changes
> handlerightmiddle --> nodeCollapsed
> handledownmiddle --> nodeExpanded
> handlerightlast --> lastNodeCollapsed
> handledownlast --> lastNodeExpanded
> The root node currently uses the handledownmiddle and the handlerightmiddle images  to show expansion and contraction. Thus the root node looks like a middle node. If we add two additional images for the root node they would be named:
>          rootNodeCollapsed
>          rootNodeExpanded
> Additionally I suggest the line image names change as follows
> lineverticalnode --> siblingMarker
> linemiddlenode --> childMarker
> linelastnode --> lastChildMarker

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
   http://issues.apache.org/jira/secure/Administrators.jspa
-
If you want more information on JIRA, or have a bug to report see:
   http://www.atlassian.com/software/jira