You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "Kevin Doran (Jira)" <ji...@apache.org> on 2021/02/09 18:19:00 UTC
[jira] [Comment Edited] (NIFI-8213) Add shellcheck to CI builds to
ensure POSIX shell compatibility
[ https://issues.apache.org/jira/browse/NIFI-8213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17281940#comment-17281940 ]
Kevin Doran edited comment on NIFI-8213 at 2/9/21, 6:18 PM:
------------------------------------------------------------
Yep, makes sense thanks [~joewitt].
[~jfrazee] thanks for the heads up. I suspected that might be the case... I suppose we could use {{warning}} severity and add shellcheck ignore comments for stuff that does not matter / we do not want to fix, ie
{noformat}
# shellcheck disable=SCxxxx{noformat}
We don't change the contents of {{/bin}} often, but it would be good to avoid regression if CI can catch it.
was (Author: kdoran):
Yep, makes sense thanks [~joewitt].
[~jfrazee] thanks for the heads up. I suspected that might be the case... I suppose we could use {{warning}} severity and add shellcheck ignore comments for stuff that does not matter / we do not want to fix, ie
{noformat}
# shellcheck disable=SCxxxx{noformat}
> Add shellcheck to CI builds to ensure POSIX shell compatibility
> ---------------------------------------------------------------
>
> Key: NIFI-8213
> URL: https://issues.apache.org/jira/browse/NIFI-8213
> Project: Apache NiFi
> Issue Type: Improvement
> Reporter: Kevin Doran
> Priority: Minor
>
> In response to NIFI-8211, I would suggest we look into adding a call to a tool such as shellcheck during our CI build to verify nifi.sh remains POSIX shell portable.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)