[GitHub] [dolphinscheduler] lenboo commented on a diff in pull request #9410: [Future-9396]Support output parameters transfer from parent workflow to child work flow

[GitBox <gi...@apache.org>]

lenboo commented on code in PR #9410:
URL: https://github.com/apache/dolphinscheduler/pull/9410#discussion_r846630689


##########
dolphinscheduler-service/src/main/java/org/apache/dolphinscheduler/service/process/ProcessServiceImpl.java:
##########
@@ -1162,11 +1165,31 @@ private String joinGlobalParams(String parentGlobalParams, String subGlobalParam
         //      e.g. the subProp's type is not equals with parent, or subProp's direct is not equals with parent
         //      It's suggested to add node name in property, this kind of problem can be solved.
         List<Property> extraSubParams = subParams.stream()
-                .filter(subProp -> !parentParamKeys.contains(subProp.getProp())).collect(Collectors.toList());
+            .filter(subProp -> !parentParamKeys.contains(subProp.getProp())).collect(Collectors.toList());
         parentParams.addAll(extraSubParams);
         return JSONUtils.toJsonString(parentParams);
     }
 
+    /**
+     * join parent global params into sub process.

Review Comment:
   comments error.
   ```suggestion
        * join parent var pool params into sub process.
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org