[Bug 55855] Unexpected WsFilter is configured in a webapp that does not use WebSocket

[bu...@apache.org]

https://bz.apache.org/bugzilla/show_bug.cgi?id=55855

--- Comment #5 from Konstantin Kolinko <kn...@gmail.com> ---
Historical notes:

(In reply to Mark Thomas from comment #2)
> I have patched 8.0.x and 7.0.x so the filter is only added if a web
> application has active WebSocket Endpoints. I think there is still merit in
> disabling the SCI since that will remove the need for the annotation scan.

1. The change described above was later reverted because of a regression: it
broke programmatic configuration of endpoints.

The regression was reported in "[VOTE] Release Apache Tomcat 8.0.0-RC9" thread.

http://tomcat.markmail.org/thread/2zmfqvveg3xhegwq

This is the reason why the WsFilter installation cannot be skipped in a web
application that uses websockets.

The change: r1551356
Reverting the change: r1552076


2. As part of review for this issue, performance of WsFilter was improved in
r1552083. Change log message: "Don't do the expensive 'Is this a WebSocket
upgrade request check' if no endpoints have been registered"

(In reply to Mark Thomas from comment #3)
> A new option, containerSciFilter, has been added to the Context in 8.0.x and
> will be included in 8.0.0 onwards.


3. Note, that "containerSciFilter" option can be used to explicitly disable
WebSocket support for a selected web application (or globally via the default
context configuration file).

http://tomcat.apache.org/tomcat-8.0-doc/config/context.html

http://wiki.apache.org/tomcat/HowTo/FasterStartUp

-- 
You are receiving this mail because:
You are the assignee for the bug.

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org