[GitHub] [doris] dutyu commented on a diff in pull request #15128: [Feature](export) Support cancel export statement

["dutyu (via GitHub)" <gi...@apache.org>]

dutyu commented on code in PR #15128:
URL: https://github.com/apache/doris/pull/15128#discussion_r1086250497


##########
fe/fe-core/src/main/java/org/apache/doris/load/ExportMgr.java:
##########
@@ -294,12 +351,12 @@ public void replayCreateExportJob(ExportJob job) {
     }
 
     public void replayUpdateJobState(long jobId, ExportJob.JobState newState) {
-        writeLock();
+        readLock();

Review Comment:
   This lock is designed to protect `idToJob` and `labelToJobId`, `replayUpdateJobState` method just read from the `idToJob`, so use a read lock may be more reasonable.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org