You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@pekko.apache.org by "pjfanning (via GitHub)" <gi...@apache.org> on 2026/08/31 22:44:42 UTC
[PR] Solr: run tests with slf4j v2, drop legacy slf4j/logback pins [pekko-connectors]
pjfanning opened a new pull request, #1881:
URL: https://github.com/apache/pekko-connectors/pull/1881
### Motivation
The Solr module was the last one pinned to slf4j 1.7 / logback 1.2 via `dependencyOverrides`, dating from the solr-solrj 8.x days when the Solr client libs did not work with slf4j v2 (#539, #611). Since the upgrade to solrj 9.x (#1813) that pin is obsolete: the Solr 9 ecosystem is slf4j-2-native.
### Modification
- Remove the slf4j/logback legacy `dependencyOverrides` and the `log4j-over-slf4j` bridge (nothing on the classpath uses the log4j 1.x API any more).
- Exclude `log4j-slf4j2-impl` from `solr-test-framework`, alongside the existing `log4j-slf4j-impl` exclusion. Under the v1 pin it was inert, but with slf4j v2 it competes with logback for provider selection, and the tests rely on the testkit's logback-based log capturing — which provider wins would otherwise be classpath-order luck. (`log4j-core` stays for solr-test-framework's own internal logging.)
- Delete the now-unused `Slf4jLegacyVersion` and `LogbackLegacyVersion` vals — Solr was their last user.
### Result
Solr tests run on slf4j-api 2.0.18 / logback-classic 1.6.3 with logback as the sole slf4j provider, matching every other connector. No trace of slf4j v1 remains in the build, and users no longer need to consider slf4j v1 `dependencyOverrides` for the Solr connector.
### Tests
- `sbt solr/test` — 21/21 pass, verified both before and after the change (embedded `MiniSolrCloudCluster`, no external services).
- Verified via `show solr/Test/fullClasspath` that slf4j-api 2.0.18 / logback-classic 1.6.3 are resolved and `logback-classic` is the only slf4j provider on the test classpath.
### References
Fixes #611
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org
Re: [PR] Solr: run tests with slf4j v2, drop legacy slf4j/logback pins [pekko-connectors]
Posted by "raboof (via GitHub)" <gi...@apache.org>.
raboof merged PR #1881:
URL: https://github.com/apache/pekko-connectors/pull/1881
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@pekko.apache.org
For additional commands, e-mail: notifications-help@pekko.apache.org