You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/11/13 13:34:57 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #30358: [SPARK-33394][SQL] Throw `NoSuchNamespaceException` for not existing namespace in `InMemoryTableCatalog.listTables()`
cloud-fan commented on a change in pull request #30358:
URL: https://github.com/apache/spark/pull/30358#discussion_r522952782
##########
File path: sql/catalyst/src/test/scala/org/apache/spark/sql/connector/catalog/TableCatalogSuite.scala
##########
@@ -813,9 +813,10 @@ class TableCatalogSuite extends SparkFunSuite {
assert(catalog.namespaceExists(testNs) === false)
- val ret = catalog.dropNamespace(testNs)
-
- assert(ret === false)
+ val errMsg = intercept[NoSuchNamespaceException] {
+ catalog.dropNamespace(testNs)
Review comment:
the previous behavior is better, that we return false if the namespace doesn't exist. Can we update `InMemoryTableCatalog.dropNamespace`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org