[GitHub] [beam] zjffdu commented on a diff in pull request #26193: [Feature Request]: Support detached mode for flink runner (#26158)

["zjffdu (via GitHub)" <gi...@apache.org>]

zjffdu commented on code in PR #26193:
URL: https://github.com/apache/beam/pull/26193#discussion_r1166136917


##########
runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkPipelineOptions.java:
##########
@@ -142,6 +142,20 @@
 
   void setNumberOfExecutionRetries(Integer retries);
 
+  @Description(
+      "Set job check interval in seconds under detached mode in method waitUntilFinish, "
+          + "by default it is 5 seconds")
+  @Default.Integer(5)
+  int getJobCheckIntervalInSecs();
+
+  void setJobCheckIntervalInSecs(int seconds);
+
+  @Description("Set the attached mode")
+  @Default.Boolean(true)
+  boolean getAttachedMode();

Review Comment:
   Thanks for the comment @Abacn , I would agree to use the same naming if it is a common option in `PipelineOptions`, but IMHO it would be better to use flink-specific terminology in `FlinkPipelineOptions` 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org