You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/11/28 13:29:59 UTC
[jira] [Commented] (WICKET-6290) CssUrlReplacer doesn't understand
data: urls and breaks them
[ https://issues.apache.org/jira/browse/WICKET-6290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15701953#comment-15701953 ]
ASF GitHub Bot commented on WICKET-6290:
----------------------------------------
GitHub user duesenklipper opened a pull request:
https://github.com/apache/wicket/pull/200
WICKET-6290 fix CssUrlReplacer so it does not mangle data URIs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/duesenklipper/wicket wicket8/WICKET-6290-cssurlreplacer-data-urls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/wicket/pull/200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #200
----
commit a8823997fbcd326baa8fafbccfc386ff01c14c4d
Author: Carl-Eric Menzel <cm...@apache.org>
Date: 2016-11-28T13:27:40Z
WICKET-6290 fix CssUrlReplacer so it does not mangle data URIs
----
> CssUrlReplacer doesn't understand data: urls and breaks them
> ------------------------------------------------------------
>
> Key: WICKET-6290
> URL: https://issues.apache.org/jira/browse/WICKET-6290
> Project: Wicket
> Issue Type: Bug
> Affects Versions: 8.0.0-M2, 6.25.0, 7.5.0, 1.5.17
> Reporter: Carl-Eric Menzel
> Assignee: Carl-Eric Menzel
>
> CssUrlReplacer tries to replace data: urls that are used to embed base64-encoded small images directly in CSS files. This leads to the following (from an adapted CssUrlReplacerTest I haven't pushed yet):
> {code}
> Expected :.class {background-image: url(data:image/gif;base64,R0lGODlhEAAQAMQAAORHH);}
> Actual :.class {background-image: url('./wicket/resource/org.apache.wicket.resource.CssUrlReplacerTest/res/css/data:image/gif;base64,R0lGODlhEAAQAMQAAORHH--decorated');}
> {code}
> It should really just leave those URLs alone. I'll prepare a pull request.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)