[jira] Commented: (HBASE-1582) Translate ColumnValueFilter and RowFilterSet to the new Filter interface

["stack (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-1582?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12724324#action_12724324 ] 

stack commented on HBASE-1582:
------------------------------

The class comment on FilterSet seems wrong (and elsewhere in javadoc).  Says Implementation of RowFilterInterface.  Should that be Filter?

Was going to suggest that we instead have a FilterList rather than FilterSet so could ordain order in which filters run but that is probably asking for trouble. Filters should be idempotent.

License should be 2009, not 2008.

Any chance of basic tests so we have some chance of knowing when we've broken these things?

On removing old filters, some of the old still work.  How about we remove those that for sure don't.  For example, call your new column filter by the old name since the old is broken (Replace old with the new)?

Otherwise, patch looks great.





> Translate ColumnValueFilter and RowFilterSet to the new Filter interface
> ------------------------------------------------------------------------
>
>                 Key: HBASE-1582
>                 URL: https://issues.apache.org/jira/browse/HBASE-1582
>             Project: Hadoop HBase
>          Issue Type: New Feature
>          Components: filters
>    Affects Versions: 0.20.0
>            Reporter: Clint Morgan
>             Fix For: 0.20.0
>
>         Attachments: 1582.patch
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.