You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@gobblin.apache.org by GitBox <gi...@apache.org> on 2019/10/09 00:01:06 UTC

[GitHub] [incubator-gobblin] sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable

sv2000 commented on a change in pull request #2758: [Gobblin-902] Enable gobblin yarn app luncher class configurable
URL: https://github.com/apache/incubator-gobblin/pull/2758#discussion_r332782796
 
 

 ##########
 File path: gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java
 ##########
 @@ -734,11 +738,11 @@ private LogCopier buildLogCopier(Config config, Path sinkLogDir, Path appWorkDir
     rawLocalFs.initialize(URI.create(ConfigurationKeys.LOCAL_FS_URI), new Configuration());
 
     LogCopier.Builder builder = LogCopier.newBuilder()
-            .useSrcFileSystem(this.fs)
-            .useDestFileSystem(rawLocalFs)
-            .readFrom(getHdfsLogDir(appWorkDir))
-            .writeTo(sinkLogDir)
-            .acceptsLogFileExtensions(ImmutableSet.of(ApplicationConstants.STDOUT, ApplicationConstants.STDERR));
+        .useSrcFileSystem(this.fs)
 
 Review comment:
   Looks like this is code reformat.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services