You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-dev@hadoop.apache.org by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org> on 2009/01/23 23:07:59 UTC
[jira] Created: (HADOOP-5119) FSEditLog and FSImage should not use
FSNamesystem.getFSNamesystem()
FSEditLog and FSImage should not use FSNamesystem.getFSNamesystem()
-------------------------------------------------------------------
Key: HADOOP-5119
URL: https://issues.apache.org/jira/browse/HADOOP-5119
Project: Hadoop Core
Issue Type: Sub-task
Components: dfs
Reporter: Tsz Wo (Nicholas), SZE
FSEditLog and FSImage should not access the namespace by the static method FSNamesystem getFSNamesystem().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HADOOP-5119) FSEditLog should not use
FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE resolved HADOOP-5119.
--------------------------------------------
Resolution: Duplicate
This was fixed as a part of HADOOP-2413.
> FSEditLog should not use FSNamesystem.getFSNamesystem()
> -------------------------------------------------------
>
> Key: HADOOP-5119
> URL: https://issues.apache.org/jira/browse/HADOOP-5119
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5119_20090323.patch, 5119_20090327.patch
>
>
> FSEditLog should not access the namespace by the static method FSNamesystem getFSNamesystem().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (HADOOP-5119) FSEditLog and FSImage should not
use FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12688949#action_12688949 ]
Tsz Wo (Nicholas), SZE commented on HADOOP-5119:
------------------------------------------------
Two options to fix FSImage:
1) pass the FSNamesystem as parameter as shown in 5119_20090323.patch.
2) add setFSNamesystem(..) and getFSNamesystem() methods to FSImage.
I originally think that option (1) is a natural fix. But option (2) seems working better for the newly introduced BackupStorage (see HADOOP-5559). Any comment?
> FSEditLog and FSImage should not use FSNamesystem.getFSNamesystem()
> -------------------------------------------------------------------
>
> Key: HADOOP-5119
> URL: https://issues.apache.org/jira/browse/HADOOP-5119
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 5119_20090323.patch
>
>
> FSEditLog and FSImage should not access the namespace by the static method FSNamesystem getFSNamesystem().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5119) FSEditLog and FSImage should not use
FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5119:
-------------------------------------------
Attachment: 5119_20090323.patch
5119_20090323.patch: pass FSNamesystem objects as parameter.
> FSEditLog and FSImage should not use FSNamesystem.getFSNamesystem()
> -------------------------------------------------------------------
>
> Key: HADOOP-5119
> URL: https://issues.apache.org/jira/browse/HADOOP-5119
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Attachments: 5119_20090323.patch
>
>
> FSEditLog and FSImage should not access the namespace by the static method FSNamesystem getFSNamesystem().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5119) FSEditLog should not use
FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5119:
-------------------------------------------
Description: FSEditLog should not access the namespace by the static method FSNamesystem getFSNamesystem(). (was: FSEditLog and FSImage should not access the namespace by the static method FSNamesystem getFSNamesystem().)
Assignee: Tsz Wo (Nicholas), SZE
Summary: FSEditLog should not use FSNamesystem.getFSNamesystem() (was: FSEditLog and FSImage should not use FSNamesystem.getFSNamesystem())
Talked to Konstantin. We agreed that (2) is a good solution to FSImage. I will fix FSImage together with its subclass BackupStorage in HADOOP-5559.
Edited issus: removed FSImage from the summary and the description.
> FSEditLog should not use FSNamesystem.getFSNamesystem()
> -------------------------------------------------------
>
> Key: HADOOP-5119
> URL: https://issues.apache.org/jira/browse/HADOOP-5119
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5119_20090323.patch
>
>
> FSEditLog should not access the namespace by the static method FSNamesystem getFSNamesystem().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HADOOP-5119) FSEditLog should not use
FSNamesystem.getFSNamesystem()
Posted by "Tsz Wo (Nicholas), SZE (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HADOOP-5119?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Tsz Wo (Nicholas), SZE updated HADOOP-5119:
-------------------------------------------
Attachment: 5119_20090327.patch
5119_20090327.patch: the problematic methods in FSEditLog are static. So, they are fixed by parameter passing.
> FSEditLog should not use FSNamesystem.getFSNamesystem()
> -------------------------------------------------------
>
> Key: HADOOP-5119
> URL: https://issues.apache.org/jira/browse/HADOOP-5119
> Project: Hadoop Core
> Issue Type: Sub-task
> Components: dfs
> Reporter: Tsz Wo (Nicholas), SZE
> Assignee: Tsz Wo (Nicholas), SZE
> Attachments: 5119_20090323.patch, 5119_20090327.patch
>
>
> FSEditLog should not access the namespace by the static method FSNamesystem getFSNamesystem().
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.