[jira] [Comment Edited] (HIVE-26691) Generate thrift files by default at compilation time

["Alessandro Solimando (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-26691?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17627739#comment-17627739 ] 

Alessandro Solimando edited comment on HIVE-26691 at 11/2/22 2:26 PM:
----------------------------------------------------------------------

+1 for mentioning in the release notes and in the wiki.

For upstream vs downstream, how do developers manage at the moment? On MacOS with brew I have multiple versions installed, and I switch with _brew unlink_ + {_}brew link{_}. This does not seem a problem to me.

For the frequency of the update, I don't think it really matters, the same line of reasoning could apply for the JVM, mvn, etc., developers are required to have a proper setup for compiling, adding or removing thrift to that does not make a significant difference.

For protobuf I guess the situation is similar, but I have never had to deal with that, I guess it can be addressed in a separate ticket.


was (Author: asolimando):
+1 for mentioning in the release notes and in the wiki.

For upstream vs downstream, how do developers manage at the moment? On MacOS with brew I have multiple versions installed, and I switch with _brew unlink_ + {_}brew link{_}. This does not seem a problem to me.

For the frequency of the update, I don't think it really matters, the same line of reasoning could apply for the JVM, mvn, etc., developers are required to have a proper setup for compiling, adding or removing thrift to that does not make a significant difference.

For protobuf I guess the situation it's similar, but I have never had to deal with that.

> Generate thrift files by default at compilation time
> ----------------------------------------------------
>
>                 Key: HIVE-26691
>                 URL: https://issues.apache.org/jira/browse/HIVE-26691
>             Project: Hive
>          Issue Type: Task
>          Components: Thrift API
>    Affects Versions: 4.0.0-alpha-2
>            Reporter: Alessandro Solimando
>            Priority: Major
>
> Currently Hive does not generate thrift files within the main compilation task ({_}mvn clean install -DskipTests{_}), but it uses a separate profile ({_}mvn clean install -Pthriftif -DskipTests -Dthrift.home=$thrift_path{_}), and thrift-generated files are generally committed in VCS.
> Other Apache projects like Parquet ([https://github.com/apache/parquet-mr/blob/master/parquet-thrift/pom.xml)] use a different approach, building all thrift files by default in the main compilation task.
> In general, generated files should not be part of our VCS, only the "source" file should be (.thrift files here).
> Including generated files in VCS is not only problematic because they are verbose and clog PR diffs, but they also generate a lot of conflicts (even when the changes over the thrift file can be merged automatically).
> The ticket proposes to move the thrift files generation at compile time, remove the thrift-generated files from VCS, and add them to the "ignore" list.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)