You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/06/28 07:01:56 UTC

[GitHub] flink pull request #6220: [FLINK-9677][rest] Cleanup encoder after request h...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/6220

    [FLINK-9677][rest] Cleanup encoder after request has been processed

    Backport of #6217.
    
    The `FileUploadHandler` may reject requests before they have been fully received, either due to an exception or because of an unknown attribute. With netty 4.1 this doesn't cause issues, but in 4.0 trailing HTTP contents still have to be handled. Since we reset the handler when encountering an error this content was forwarded to the next handler which crashed the http aggregator.
    
    This PR introduces a flag such that all http contents are swallowed after a failure, until a new `HttpRequest` is received.
    
    @tillrohrmann 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 9677_15

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/6220.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #6220
    
----
commit 3ef17b389ccb0d7694a166756b003f1970c40df2
Author: zentol <ch...@...>
Date:   2018-06-27T07:34:34Z

    [FLINK-9677][rest] Cleanup encoder after request has been processed

----


---

[GitHub] flink issue #6220: [FLINK-9677][rest] Cleanup encoder after request has been...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6220
  
    Note that the whole resetting logic in the `FileUploadHandler` is rather funky anyways; the handler isn't shareable and thus a handler instance only processes a single request, but the handler is written as if that weren't the case.


---

[GitHub] flink issue #6220: [FLINK-9677][rest] Cleanup encoder after request has been...

Posted by zentol <gi...@git.apache.org>.

Github user zentol commented on the issue:

    https://github.com/apache/flink/pull/6220
  
    merged.


---

[GitHub] flink pull request #6220: [FLINK-9677][rest] Cleanup encoder after request h...

Posted by zentol <gi...@git.apache.org>.

Github user zentol closed the pull request at:

    https://github.com/apache/flink/pull/6220


---