[GitHub] [incubator-gobblin] hanghangliu commented on a change in pull request #2990: Gobblin 1148 improve hive test coverage

[GitBox <gi...@apache.org>]

hanghangliu commented on a change in pull request #2990:
URL: https://github.com/apache/incubator-gobblin/pull/2990#discussion_r431921993



##########
File path: gobblin-hive-registration/src/test/java/org/apache/gobblin/hive/metastore/HiveMetaStoreUtilsTest.java
##########
@@ -165,4 +169,47 @@ public void testInVokeDetermineSchemaOrThrowExceptionMethod() {
       Assert.assertFalse(e instanceof NoSuchMethodException);
     }
   }
+
+  @Test
+  public void testgetHiveTable() throws Exception {

Review comment:
       hive-test.json is just a dummy file, since I need a sub-directory for testing hive snapshot. Git won't accept an empty directory. I changed it to a .gitignore file for maintaining a dummy directory since this way makes more sense. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org