You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/07/04 09:30:00 UTC

[jira] [Commented] (FLINK-6822) Activate checkstyle for runtime/plugable

    [ https://issues.apache.org/jira/browse/FLINK-6822?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16073389#comment-16073389 ] 

ASF GitHub Bot commented on FLINK-6822:
---------------------------------------

Github user zentol commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4064#discussion_r125429424
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/plugable/ReusingDeserializationDelegate.java ---
    @@ -16,33 +16,31 @@
      * limitations under the License.
      */
     
    -
     package org.apache.flink.runtime.plugable;
     
    -import java.io.IOException;
    -
     import org.apache.flink.api.common.typeutils.TypeSerializer;
     import org.apache.flink.core.memory.DataInputView;
     import org.apache.flink.core.memory.DataOutputView;
     
    +import java.io.IOException;
     
    +/**
    + * A {@link DeserializationDelegate} that reuses an existing instance upon deserialization.
    + */
     public class ReusingDeserializationDelegate<T> implements DeserializationDelegate<T> {
    -	
    +
     	private T instance;
    -	
    +
     	private final TypeSerializer<T> serializer;
    -	
     
     	public ReusingDeserializationDelegate(TypeSerializer<T> serializer) {
     		this.serializer = serializer;
     	}
    -	
    -	@Override
    --- End diff --
    
    don't know why that happened, will revert the removal.


> Activate checkstyle for runtime/plugable
> ----------------------------------------
>
>                 Key: FLINK-6822
>                 URL: https://issues.apache.org/jira/browse/FLINK-6822
>             Project: Flink
>          Issue Type: Improvement
>          Components: Local Runtime
>            Reporter: Chesnay Schepler
>            Assignee: Chesnay Schepler
>            Priority: Trivial
>             Fix For: 1.4.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)