[jira] [Commented] (SOLR-8734) fix deprecation warnings for absent (maxMergeDocs|mergeFactor)

["Shai Erera (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/SOLR-8734?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15167049#comment-15167049 ] 

Shai Erera commented on SOLR-8734:
----------------------------------

Patch looks good. Even while working on the previous issue I thought that we should be able to detect the existence of {{<mergeFactor>}} element in the .xml, and not compare the value to the default. What happens if someone includes both {{<mergePolicyFactory>}} and {{<mergeFactor>}} set to the default value? Would we also fail?

> fix deprecation warnings for absent (maxMergeDocs|mergeFactor)
> --------------------------------------------------------------
>
>                 Key: SOLR-8734
>                 URL: https://issues.apache.org/jira/browse/SOLR-8734
>             Project: Solr
>          Issue Type: Bug
>    Affects Versions: 5.5, master
>            Reporter: Christine Poerschke
>            Assignee: Christine Poerschke
>         Attachments: SOLR-8734.patch, SOLR-8734.patch
>
>
> [~markus17] wrote on the solr-user mailing list:
> bq. 5.5.0 SOLR-8621 deprecation warnings without maxMergeDocs or mergeFactor
> ...
> bq. o.a.s.c.Config Beginning with Solr 5.5, <maxMergeDocs> is deprecated, configure it on the relevant <mergePolicyFactory> instead.
> ...
> bq. On my development machine for all cores. None of the cores has either parameter configured. Is this expected?
> ...
> [~cpoerschke] replied:
> ...
> bq. Could you advise if/that the solrconfig.xml has a <mergePolicy> element (for which deprecated warnings would appear separately) or that the solrconfig.xml has no <mergePolicyFactory> element?
> ...
> bq. If either is the case then yes based on the code (SolrIndexConfig.java#L153) the warnings would be expected-and-harmless though admittedly are confusing, and fixable.
> ...



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org