You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@uima.apache.org by cw...@apache.org on 2014/04/01 16:32:36 UTC
svn commit: r1583685 -
/uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/metrics/collectors/DuccGarbageStatsCollector.java
Author: cwiklik
Date: Tue Apr 1 14:32:36 2014
New Revision: 1583685
URL: http://svn.apache.org/r1583685
Log:
UIMA-3714 fix how garbage collector accumulates GC counts and totals
Modified:
uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/metrics/collectors/DuccGarbageStatsCollector.java
Modified: uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/metrics/collectors/DuccGarbageStatsCollector.java
URL: http://svn.apache.org/viewvc/uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/metrics/collectors/DuccGarbageStatsCollector.java?rev=1583685&r1=1583684&r2=1583685&view=diff
==============================================================================
--- uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/metrics/collectors/DuccGarbageStatsCollector.java (original)
+++ uima/sandbox/uima-ducc/trunk/uima-ducc-agent/src/main/java/org/apache/uima/ducc/agent/metrics/collectors/DuccGarbageStatsCollector.java Tue Apr 1 14:32:36 2014
@@ -70,29 +70,17 @@ public class DuccGarbageStatsCollector {
String gcCollectorName = gcObject.getObjectName().getCanonicalKeyPropertyListString();
ObjectName memoryManagerMXBean =
new ObjectName("java.lang:" + gcCollectorName);
- totalCollectionCount =+ (Long) connection.getAttribute(memoryManagerMXBean,"CollectionCount");
- totalCollectionTime =+ (Long) connection.getAttribute(memoryManagerMXBean,"CollectionTime");
+ totalCollectionCount += (Long) connection.getAttribute(memoryManagerMXBean,"CollectionCount");
+ totalCollectionTime += (Long) connection.getAttribute(memoryManagerMXBean,"CollectionTime");
}
// Returns the total number of collections that have occurred.
gcStats.setCollectionCount(totalCollectionCount);
// Returns the approximate accumulated collection elapsed time in milliseconds.
gcStats.setCollectionTime(totalCollectionTime);
-
} catch( Exception e) {
logger.error("", null, "Failed to Fetch JMX GC Stats From PID:"+process.getPID()+" Reason:\n"+e);
}
-
-
-// List<GarbageCollectorMXBean> gcmb = ManagementFactory.getGarbageCollectorMXBeans();
-// for( GarbageCollectorMXBean gcBean : gcmb ) {
-// gcStats.setMemoryManagerName(gcBean.getName());
-// // Returns the total number of collections that have occurred.
-// gcStats.setCollectionCount(gcBean.getCollectionCount());
-// // Returns the approximate accumulated collection elapsed time in milliseconds.
-// gcStats.setCollectionTime(gcBean.getCollectionTime());
- //}
-
}
return gcStats;
}