You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2023/12/21 01:32:53 UTC
[PR] register cpc teardown functions for std::atexit [datasketches-cpp]
jmalkin opened a new pull request, #412:
URL: https://github.com/apache/datasketches-cpp/pull/412
`std::atexit()` is apparently considered a legacy C thing since C++ should ideally be able to use static objects. Regardless, this worked to clean up: When I tested in valgrind we finally had a clean report for CPC for the first time ever.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] register cpc teardown functions for std::atexit [datasketches-cpp]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #412:
URL: https://github.com/apache/datasketches-cpp/pull/412#issuecomment-1865355616
## Pull Request Test Coverage Report for [Build 7282853175](https://coveralls.io/builds/64699535)
* **6** of **6** **(100.0%)** changed or added relevant lines in **1** file are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage increased (+**0.001%**) to **98.939%**
---
| Totals | [](https://coveralls.io/builds/64699535) |
| :-- | --: |
| Change from base [Build 7205830121](https://coveralls.io/builds/64560696): | 0.001% |
| Covered Lines: | 16039 |
| Relevant Lines: | 16211 |
---
##### 💛 - [Coveralls](https://coveralls.io)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] register cpc teardown functions for std::atexit [datasketches-cpp]
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin merged PR #412:
URL: https://github.com/apache/datasketches-cpp/pull/412
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org