You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "alamb (via GitHub)" <gi...@apache.org> on 2024/11/26 18:57:16 UTC
[PR] Rename `TokenWithLocation` to `TokenWithSpan`, in backwards compatible way [datafusion-sqlparser-rs]
alamb opened a new pull request, #1562:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1562
# Rationale
While working on
- https://github.com/apache/datafusion-sqlparser-rs/pull/1549
I noticed that `TokenWithLocation` was confusingly named as after https://github.com/apache/datafusion-sqlparser-rs/pull/1435 it contains a `Span` rather than a `Location`
# Changes
1. Rename `TokenWithLocation` to `TokenWithSpan`
2. Leave a (deprecated) typedef pointing at `TokenWithLocation` to help migration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Rename `TokenWithLocation` to `TokenWithSpan`, in backwards compatible way [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb merged PR #1562:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1562
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Rename `TokenWithLocation` to `TokenWithSpan`, in backwards compatible way [datafusion-sqlparser-rs]
Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #1562:
URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1562#issuecomment-2508953666
Thanks @iffyio
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org