You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/14 07:35:09 UTC

[GitHub] [beam] zhoufek commented on a change in pull request #15003: [BEAM-9487] Disable GBK safety checks by default

zhoufek commented on a change in pull request #15003:
URL: https://github.com/apache/beam/pull/15003#discussion_r650279852



##########
File path: CHANGES.md
##########
@@ -103,10 +103,13 @@
   it was ignored if provided.
 * `TopCombineFn` disallow `compare` as its argument (Python) ([BEAM-7372](https://issues.apache.org/jira/browse/BEAM-7372)).
 * Drop support for Flink 1.10 ([BEAM-12281](https://issues.apache.org/jira/browse/BEAM-12281)).
+* Custom implementations of `TriggerFn` now require that `may_lose_data` be implemented ([BEAM-9487](https://issues.apache.org/jira/browse/BEAM-9487)).

Review comment:
       This is due to adding an abstract method. Unsure if we should avoid making it abstract until 2.33.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org