You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@karaf.apache.org by "Benjamin Reed (JIRA)" <ji...@apache.org> on 2012/05/31 18:37:22 UTC
[jira] [Created] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Benjamin Reed created KARAF-1515:
------------------------------------
Summary: features-generate-descriptor does not set the version in generated features
Key: KARAF-1515
URL: https://issues.apache.org/jira/browse/KARAF-1515
Project: Karaf
Issue Type: Bug
Components: karaf-tooling
Affects Versions: 3.0.0
Reporter: Benjamin Reed
Fix For: 3.0.0
When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Work started] (KARAF-1515) features-generate-descriptor
does not set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Work on KARAF-1515 started by Freeman Fang.
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1515) features-generate-descriptor does
not set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13287131#comment-13287131 ]
Freeman Fang commented on KARAF-1515:
-------------------------------------
Hi Benjamin,
Please re-attach your patch with "Grant Apache License".
Thanks
Freeman
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated KARAF-1515:
---------------------------------
Attachment: KARAF-1515.patch
Attached is a patch that resolves this, by adding the "hasVersion()" boolean method to the Feature object, and then checks that boolean in the karaf-maven-plugin when creating a features.xml file.
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated KARAF-1515:
---------------------------------
Attachment: KARAF-1515.patch
Could have sworn I did, but here it is again...
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (KARAF-1515) features-generate-descriptor does
not set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang resolved KARAF-1515.
---------------------------------
Resolution: Fixed
apply patch on behalf of Benjamin with thanks
http://svn.apache.org/viewvc?rev=1345810&view=rev
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Posted by "Benjamin Reed (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Benjamin Reed updated KARAF-1515:
---------------------------------
Attachment: (was: KARAF-1515.patch)
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Assigned] (KARAF-1515) features-generate-descriptor does
not set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang reassigned KARAF-1515:
-----------------------------------
Assignee: Freeman Fang
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated KARAF-1515:
--------------------------------
Attachment: KARAF-1515.patch
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (KARAF-1515) features-generate-descriptor does
not set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13288297#comment-13288297 ]
Freeman Fang commented on KARAF-1515:
-------------------------------------
Hi Benjamin,
Just found the jira patch attachment doesn't work properly, so even you select the "Grant Apache License" radio button, still can't see the Apache feather icon with the attachment, this is the Apache Jira issue.
Back to your patch, just one thing, webconsole/features/src/main/java/org/apache/karaf/webconsole/features/ExtendedFeature.java implements Feature, but you didn't add new hasVersion() method for that class which cause compilation error. So next time when you attach patch, you need ensure it doesn't break any compilation and tests.
I just add that minor change and will apply your patch soon.
Thanks for the patch.
Freeman
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated KARAF-1515:
--------------------------------
Attachment: KARAF-1515.patch
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (KARAF-1515) features-generate-descriptor does not
set the version in generated features
Posted by "Freeman Fang (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/KARAF-1515?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Freeman Fang updated KARAF-1515:
--------------------------------
Attachment: (was: KARAF-1515.patch)
> features-generate-descriptor does not set the version in generated features
> ---------------------------------------------------------------------------
>
> Key: KARAF-1515
> URL: https://issues.apache.org/jira/browse/KARAF-1515
> Project: Karaf
> Issue Type: Bug
> Components: karaf-tooling
> Affects Versions: 3.0.0
> Reporter: Benjamin Reed
> Assignee: Freeman Fang
> Fix For: 3.0.0
>
> Attachments: KARAF-1515.patch
>
>
> When using features-generate-descriptor, the generated features.xml does not set a version. It appears to be because the Feature model checks for null in getVersion(), so it's always returning either the set version string, or the string "0.0.0".
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira