You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by pratik pandey <pr...@gmail.com> on 2018/03/07 11:45:54 UTC
Review Request 65948: ATLAS-2483 : UI - Display of faceted query
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65948/
-----------------------------------------------------------
Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
Bugs: ATLAS-2483
https://issues.apache.org/jira/browse/ATLAS-2483
Repository: atlas
Description
-------
On searching using basic search :
type = hive_column
filter = position != 1
the applied search is displayed as Type: hive_column AND (AND (position != 1))
In earlier versions , when OR support wasn't there in UI , same query would display Type: hive_table AND retention = 1
"hive_column AND (AND (position != 1))" is confusing to user.
Diffs
-----
dashboardv2/public/js/utils/CommonViewFunction.js 2057e3e
Diff: https://reviews.apache.org/r/65948/diff/1/
Testing
-------
Done one round of sanity testing.
Thanks,
pratik pandey
Re: Review Request 65948: ATLAS-2483 : UI - Display of faceted query
Posted by keval bhatt <kb...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65948/#review198876
-----------------------------------------------------------
Ship it!
Ship It!
- keval bhatt
On March 7, 2018, 11:45 a.m., pratik pandey wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65948/
> -----------------------------------------------------------
>
> (Updated March 7, 2018, 11:45 a.m.)
>
>
> Review request for atlas, keval bhatt, Madhan Neethiraj, Nixon Rodrigues, and Sharmadha Sainath.
>
>
> Bugs: ATLAS-2483
> https://issues.apache.org/jira/browse/ATLAS-2483
>
>
> Repository: atlas
>
>
> Description
> -------
>
> On searching using basic search :
>
> type = hive_column
> filter = position != 1
> the applied search is displayed as Type: hive_column AND (AND (position != 1))
> In earlier versions , when OR support wasn't there in UI , same query would display Type: hive_table AND retention = 1
>
> "hive_column AND (AND (position != 1))" is confusing to user.
>
>
> Diffs
> -----
>
> dashboardv2/public/js/utils/CommonViewFunction.js 2057e3e
>
>
> Diff: https://reviews.apache.org/r/65948/diff/1/
>
>
> Testing
> -------
>
> Done one round of sanity testing.
>
>
> Thanks,
>
> pratik pandey
>
>