You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@guacamole.apache.org by "Jimmy (Jira)" <ji...@apache.org> on 2020/06/17 16:42:00 UTC
[jira] [Updated] (GUACAMOLE-1104) Remove the multiple calls of guac_rdp_disp_update_size() function in the guacamole server

     [ https://issues.apache.org/jira/browse/GUACAMOLE-1104?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jimmy updated GUACAMOLE-1104:
-----------------------------
    Description: 
While using the guacamole server, I found that the guac_rdp_disp_update_size() function is unnecessarily several times called.

This function is called when resizing the browser.
 The call stack of this function follows as below:
 !image-2020-06-17-19-25-20-220.png!
  
 This call is normal.
 But this function is continuously called in the loop of the guac_rdp_handle_connection() function regardless of the resizing of the browser.
 !image-2020-06-17-19-32-30-990.png!
  
 I removed the call and tested the relevant features such as resizing.
 It works well.

So I think that we have to remove this call.
If this issue is accepted by you, I want to fix it myself.

Thanks.

  was:
While using the guacamole server, I found that the guac_rdp_disp_update_size() function is unnecessarily several times called.

This function is called when resizing the browser.
The call stack of this function follows as below:
!image-2020-06-17-19-25-20-220.png!
 
This call is normal.
But this function is continuously called in the loop of the guac_rdp_handle_connection() function regardless of the resizing of the browser.
!image-2020-06-17-19-32-30-990.png!
 
I removed the call and tested the relevant features such as resizing.
It works well.

So I think that we have to remove this call.
Thanks.


> Remove the multiple calls of guac_rdp_disp_update_size() function in the guacamole server
> -----------------------------------------------------------------------------------------
>
>                 Key: GUACAMOLE-1104
>                 URL: https://issues.apache.org/jira/browse/GUACAMOLE-1104
>             Project: Guacamole
>          Issue Type: Improvement
>          Components: guacamole-server, RDP
>    Affects Versions: 1.1.0
>            Reporter: Jimmy
>            Priority: Minor
>              Labels: easyfix
>             Fix For: 1.2.0
>
>         Attachments: image-2020-06-17-19-25-20-220.png, image-2020-06-17-19-32-30-990.png
>
>
> While using the guacamole server, I found that the guac_rdp_disp_update_size() function is unnecessarily several times called.
> This function is called when resizing the browser.
>  The call stack of this function follows as below:
>  !image-2020-06-17-19-25-20-220.png!
>   
>  This call is normal.
>  But this function is continuously called in the loop of the guac_rdp_handle_connection() function regardless of the resizing of the browser.
>  !image-2020-06-17-19-32-30-990.png!
>   
>  I removed the call and tested the relevant features such as resizing.
>  It works well.
> So I think that we have to remove this call.
> If this issue is accepted by you, I want to fix it myself.
> Thanks.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)