You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/08/26 18:01:03 UTC

[GitHub] [beam] damccorm commented on a diff in pull request #22897: Add map state in the Go Sdk

damccorm commented on code in PR #22897:
URL: https://github.com/apache/beam/pull/22897#discussion_r956288147


##########
sdks/go/pkg/beam/core/state/state_test.go:
##########
@@ -116,6 +117,50 @@ func (s *fakeProvider) ExtractOutputFn(userStateID string) reflectx.Func {
 	return nil
 }
 
+// ReadMapStateValue(userStateID string, key interface{}) (interface{}, []Transaction, error)

Review Comment:
   Whoops, no this is just a leftover bad copy paste as I moved the definitions over. I shouldn't need doc comments for test functions, but I did remove these. Good catch!



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org