You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@commons.apache.org by "Sean C. Sullivan" <se...@seansullivan.com> on 2002/02/17 08:06:05 UTC

[httpclient] patch for HttpClient.java

 This is a patch for HttpClient.java

 The patch file, HttpClient.patch,  is attached.

 I created the patch files using this command:

                cvs diff -u Foo.java > Foo.patch

Changes:

     executeMethod now checks for a null parameter.

     executeMethod will now throw an IllegalStateException if the
     session has not been started

     updated javadoc comments for: getState, setState, startSession,
endSession,
     and executeMethod

I executed the tests and everything passed.

-Sean

Re: [httpclient] patch for HttpMethodBase.java

Posted by dIon Gillard <di...@multitask.com.au>.

Applied and fixed formatting

Sean C. Sullivan wrote:

>This is a patch for HttpMethodBase.java
>
>The patch file, HttpMethodBase.patch,  is attached.
>
>I created the patch file using this command:
> 
>                 cvs diff -u Foo.java > Foo.patch
> 
>Changes:
>
>      the execute method will now check for null parameters
>
>      updated javadoc comments for: execute
>
>      added "log.isDebugEnabled" for each log.debug statement
>
>
>I executed the tests and everything passed.
> 
>-Sean
>
-- 
dIon Gillard, Multitask Consulting
http://www.multitask.com.au/developers




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

[httpclient] patch for RequestOutputStream.java

Posted by "Sean C. Sullivan" <se...@seansullivan.com>.

Here is another patch for RequestOutputStream.java

A patch file is attached.

 I created the patch file using this command:

                   cvs diff -u Foo.java > Foo.patch

Changes in RequestOutputStream:

    updated the class javadoc with an "@see"
    fixed erroneous javadoc parameter comments
    the method "public void print(String)" will no longer accept a null
parameter

 I executed the tests and everything passed.

-Sean

Re: [httpclient] patches for RequestOutputStream.java, ResponseInputStream.java

Posted by dIon Gillard <di...@multitask.com.au>.

Sean C. Sullivan wrote:

>Here are patches for RequestOutputStream.java and  ResponseInputStream.java
> 
>Two patch files are attached.
> 
>I created the patch files using this command:
>  
>                  cvs diff -u Foo.java > Foo.patch
>  
> Changes in RequestOutputStream:
>
>    removed email address for Sean C. Sullivan
>
>    fixed the erroneous comment for the OutputStream member variable
>
>    the close() method now makes use of the "close" member variable
>
Applied.

>
>
>Changes in ResponseInputStream:
>
>    removed email address for Sean C. Sullivan
>
>    added method:  public boolean isUsingChunking
>
Only applied removal of email address as method (isUsingChunking) is not 
called anywhere.

>
>I executed the tests and everything passed.
>  
> -Sean
>
Thanks again.

>
-- 
dIon Gillard, Multitask Consulting
http://www.multitask.com.au/developers




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>

[httpclient] patches for RequestOutputStream.java, ResponseInputStream.java

Posted by "Sean C. Sullivan" <se...@seansullivan.com>.

Here are patches for RequestOutputStream.java and  ResponseInputStream.java
 
Two patch files are attached.
 
I created the patch files using this command:
  
                  cvs diff -u Foo.java > Foo.patch
  
 Changes in RequestOutputStream:

    removed email address for Sean C. Sullivan

    fixed the erroneous comment for the OutputStream member variable

    the close() method now makes use of the "close" member variable

Changes in ResponseInputStream:

    removed email address for Sean C. Sullivan

    added method:  public boolean isUsingChunking

I executed the tests and everything passed.
  
 -Sean

[httpclient] patch for HttpMethodBase.java

Posted by "Sean C. Sullivan" <se...@seansullivan.com>.

This is a patch for HttpMethodBase.java

The patch file, HttpMethodBase.patch,  is attached.

I created the patch file using this command:
 
                 cvs diff -u Foo.java > Foo.patch
 
Changes:

      the execute method will now check for null parameters

      updated javadoc comments for: execute

      added "log.isDebugEnabled" for each log.debug statement


I executed the tests and everything passed.
 
-Sean

Re: [httpclient] patch for HttpClient.java

Posted by dIon Gillard <di...@multitask.com.au>.

Applied and fixed formatting.

Sean C. Sullivan wrote:

> This is a patch for HttpClient.java
>
> The patch file, HttpClient.patch,  is attached.
>
> I created the patch files using this command:
>
>                cvs diff -u Foo.java > Foo.patch
>
>Changes:
>
>     executeMethod now checks for a null parameter.
>
>     executeMethod will now throw an IllegalStateException if the
>     session has not been started
>
>     updated javadoc comments for: getState, setState, startSession,
>endSession,
>     and executeMethod
>
>I executed the tests and everything passed.
>
>-Sean
>
>
>------------------------------------------------------------------------
>
>--
>To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
>For additional commands, e-mail: <ma...@jakarta.apache.org>
>


-- 
dIon Gillard, Multitask Consulting
http://www.multitask.com.au/developers




--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>