You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "ramkrishna.s.vasudevan (JIRA)" <ji...@apache.org> on 2015/04/21 06:57:58 UTC

[jira] [Commented] (HBASE-13501) Deprecate/Remove getComparator() in HRegionInfo.

    [ https://issues.apache.org/jira/browse/HBASE-13501?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14504327#comment-14504327 ] 

ramkrishna.s.vasudevan commented on HBASE-13501:
------------------------------------------------

When we talk about removing getComparator in HRegionInfo which is marked public, ideally HRegionInfo should not have been public.
The only place where we expose that is in Admin.java
{code}
  /**
   * Close a region.  For expert-admins  Runs close on the regionserver.  The master will not be
   * informed of the close.
   *
   * @param sn
   * @param hri
   * @throws IOException
   */
  void closeRegion(final ServerName sn, final HRegionInfo hri) throws IOException;
{code}
Here we really don't need an HRegionInfo which could have been always created from a TableName.  I would say we could deprecate/remove these methods so that HRegionInfo can go to LimitedPrivate so that atleast CPs can use it and not a direct client facing Interface.
Thoughts?

> Deprecate/Remove getComparator() in HRegionInfo.
> ------------------------------------------------
>
>                 Key: HBASE-13501
>                 URL: https://issues.apache.org/jira/browse/HBASE-13501
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: ramkrishna.s.vasudevan
>            Assignee: ramkrishna.s.vasudevan
>             Fix For: 2.0.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)