You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@netbeans.apache.org by GitBox <gi...@apache.org> on 2022/12/26 19:46:24 UTC

[GitHub] [netbeans] Atrament666 opened a new pull request, #5155: Fix missing ICON_RESOURCE in git tag actions

Atrament666 opened a new pull request, #5155:
URL: https://github.com/apache/netbeans/pull/5155

   This PR adds missing IMAGE_RESOURCE in actions related to git tag operations. Because of the missing IMAGE_RESOURCES the toolbar configuration tool couldn't find them.
   
   Fixes #4914
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] Atrament666 commented on a diff in pull request #5155: Fix missing ICON_RESOURCE in git tag actions

Posted by GitBox <gi...@apache.org>.
Atrament666 commented on code in PR #5155:
URL: https://github.com/apache/netbeans/pull/5155#discussion_r1057356676


##########
ide/git/src/org/netbeans/modules/git/ui/tag/ManageTagsAction.java:
##########
@@ -47,24 +47,34 @@
 public class ManageTagsAction extends SingleRepositoryAction {
 
     private static final Logger LOG = Logger.getLogger(ManageTagsAction.class.getName());
+    private static final String ICON_RESOURCE = "org/netbeans/modules/git/resources/icons/tags.png"; //NOI18N
+
+    public ManageTagsAction() {
+        super(ICON_RESOURCE);
+    }
+
+    @Override
+    protected String iconResource() {
+        return ICON_RESOURCE;
+    }
 
     @Override
-    protected void performAction (File repository, File[] roots, VCSContext context) {
+    protected void performAction(File repository, File[] roots, VCSContext context) {

Review Comment:
   I reverted the formatting changes, I hope that the new commit is ok...



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #5155: Fix missing ICON_RESOURCE in git tag actions

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5155:
URL: https://github.com/apache/netbeans/pull/5155#issuecomment-1365907553

   @Atrament666 thank you for the update. The final commit looks good. I just pushed an update into your branch, that dropped the first 2 commits from the branch. Before my push, the history looked like this:
   
   - original change
   - revert original change
   - updated change
   
   With the push it is down to
   
   - updated change
   
   When the Unittest runs come back clean, I'll merge.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on pull request #5155: Fix missing ICON_RESOURCE in git tag actions

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on PR #5155:
URL: https://github.com/apache/netbeans/pull/5155#issuecomment-1366001873

   Merging - Thank you @Atrament666 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #5155: Fix missing ICON_RESOURCE in git tag actions

Posted by GitBox <gi...@apache.org>.
matthiasblaesing commented on code in PR #5155:
URL: https://github.com/apache/netbeans/pull/5155#discussion_r1057350989


##########
ide/git/src/org/netbeans/modules/git/ui/tag/ManageTagsAction.java:
##########
@@ -47,24 +47,34 @@
 public class ManageTagsAction extends SingleRepositoryAction {
 
     private static final Logger LOG = Logger.getLogger(ManageTagsAction.class.getName());
+    private static final String ICON_RESOURCE = "org/netbeans/modules/git/resources/icons/tags.png"; //NOI18N
+
+    public ManageTagsAction() {
+        super(ICON_RESOURCE);
+    }
+
+    @Override
+    protected String iconResource() {
+        return ICON_RESOURCE;
+    }
 
     @Override
-    protected void performAction (File repository, File[] roots, VCSContext context) {
+    protected void performAction(File repository, File[] roots, VCSContext context) {

Review Comment:
   The formatting changes here and below should be reverted.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists

[GitHub] [netbeans] matthiasblaesing merged pull request #5155: Fix missing ICON_RESOURCE in git tag actions

Posted by GitBox <gi...@apache.org>.
matthiasblaesing merged PR #5155:
URL: https://github.com/apache/netbeans/pull/5155


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists