[GitHub] [activemq-artemis] gemmellr commented on pull request #2695: ARTEMIS-2372 Filtering on Message Annotations

[GitBox <gi...@apache.org>]

gemmellr commented on pull request #2695:
URL: https://github.com/apache/activemq-artemis/pull/2695#issuecomment-621148356


   I dont think this should have been added before https://issues.apache.org/jira/browse/ARTEMIS-2740 is addressed. I know that JIRA is new, but I see the issue was raised in comments here when this PR was raised last year, and the PR closed, but now reopened/updated and added anyway - with the tests still using annotations that are reserved. It seems unwise to add a new functionality that relies on/encourages this behaviour, given fixing that would then necessarily break any uses of this new functionality.
   
   It also seems that now any use of filters where the key value isnt found in application properties is going to decode every annotation now. Unlikely to be great for performance, and especially not nice for folks who aren't even looking to filter on any annotations, which is likely to be most values for most people, and certainly every existing user up to this point given it wasn't even possible before.
   
   The filter extensions spec in the AMQP TC (https://www.oasis-open.org/committees/document.php?document_id=66227) is currently proposing using "m.<annotation-key>" as a means of requesting filtering on the message-annotations map within an SQL based filter string. It might be worth aligning to that, as it would at least allow avoiding decoding annotations when folks have not asked for them to be filtered.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org