[GitHub] [datasketches-cpp] jmalkin commented on a diff in pull request #342: Remove inheritance from std::iterator

["jmalkin (via GitHub)" <gi...@apache.org>]

jmalkin commented on code in PR #342:
URL: https://github.com/apache/datasketches-cpp/pull/342#discussion_r1093655433


##########
fi/include/reverse_purge_hash_map.hpp:
##########
@@ -91,8 +91,14 @@ class reverse_purge_hash_map {
 
 // This iterator uses strides based on golden ratio to avoid clustering during merge
 template<typename K, typename V, typename H, typename E, typename A>
-class reverse_purge_hash_map<K, V, H, E, A>::iterator: public std::iterator<std::input_iterator_tag, K> {
+class reverse_purge_hash_map<K, V, H, E, A>::iterator {
 public:
+  using iterator_category = std::input_iterator_tag;
+  using value_type = std::pair<K&, V>;
+  using difference_type = std::ptrdiff_t;

Review Comment:
   Good point



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org