You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/01/13 09:41:10 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
shwstppr opened a new pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857
### Description
Fixes #5830
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1030405295
<b>Trillian test result (tid-3158)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 32479 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5857-t3158-kvm-centos7.zip
Smoke tests completed. 92 look OK, 0 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798559105
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
@sureshanaparti do we need to consider even ISO size for resource limit check done at line 3863? cc @DaanHoogland @rohityadavcloud @weizhouapache
I've made the change as VMs deployed using ISOs will always have root volume created from the specified disk offering and ISO size shouldn't be considered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025757694
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1027712130
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1027711207
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029903287
> @sureshanaparti I don't think the config applies to cumulative VM volume size. In my understanding it is for individual volumes.
> I'll check and update for offering's root disk size and size mismatch in error message
@shwstppr Verified the cases not working as expected, with the latest changes. Invalid error message in one case, check below.
- Deployed VM with 9 GB ROOT disk and 3 GB Data Disk [Passd, Working as expected]
- Deployed VM with ISO, having 11 GB custom disk offering [Failed, Works as expected]
- Deployed VM with ISO, having 20 GB fixed disk offering [Failed, Works as expected]
- Deployed VM with ISO, having 9 GB custom disk offering [Passed, Working as expected]
- Created Compute Offering with ROOT disk size 11 GB [Failed, Working as expected]
- **Deployed VM with Compute Offering having ROOT disk size 11 GB disk [Failed, Working as expected, But wrong error message - Please specify a size of at least 1 GB.]**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1016375893
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1016418769
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2248
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017755921
<b>Trillian test result (tid-2928)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 31327 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5857-t2928-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_08_arping_in_ssvm | `Failure` | 5.16 | test_diagnostics.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017232335
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r799376841
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
agree @DaanHoogland
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025821055
@DaanHoogland a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1026506953
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031191717
> > @sureshanaparti I don't think the config applies to cumulative VM volume size. In my understanding it is for individual volumes.
> > I'll check and update for offering's root disk size and size mismatch in error message
>
> @shwstppr Verified the cases not working as expected, with the latest changes. Invalid error message in one case, check below.
>
> * Deployed VM with 9 GB ROOT disk and 3 GB Data Disk [Passd, Working as expected]
> * Deployed VM with ISO, having 11 GB custom disk offering [Failed, Works as expected]
> * Deployed VM with ISO, having 20 GB fixed disk offering [Failed, Works as expected]
> * Deployed VM with ISO, having 9 GB custom disk offering [Passed, Working as expected]
> * Created Compute Offering with ROOT disk size 11 GB [Failed, Working as expected]
> * **Deployed VM with Compute Offering having ROOT disk size 11 GB disk [Failed, Working as expected, But wrong error message - Please specify a size of at least 1 GB.]**
Verified the error message with the latest changes. LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031127510
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025757224
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland removed a comment on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
DaanHoogland removed a comment on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025817870
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028625581
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017607677
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2265
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017564378
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031211274
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017563128
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017223265
Add test details in description
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028990137
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r797400931
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
+ throw new InvalidParameterValueException(String.format("Requested volume size is %d, but the maximum size allowed is %d GB.", size, maxVolumeSize));
Review comment:
@sureshanaparti I've made the change to fix this.
I see you've started a new test run. I don't think this change affects results. Up to you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029094221
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031127926
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029917204
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798566755
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
Makes sense from a logical viewpoint but as an operator, will the ISO not also take its space on primary, i.e. will the user not have to be charged for that space?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r799355087
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
ok, as long as it's clear and consistent we can always revisit. @sureshanaparti, agree ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1026292720
<b>Trillian test result (tid-3081)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 28000 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5857-t3081-kvm-centos7.zip
Smoke tests completed. 80 look OK, 12 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3.42 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 4.42 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 4.33 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 3.31 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 4.34 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 4.29 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3.22 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 4.24 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 4.35 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 63.51 | test_kubernetes_clusters.py
test_01_native_to_native_network_migration | `Error` | 10.11 | test_migration.py
test_02_native_to_native_vpc_migration | `Error` | 6.80 | test_migration.py
ContextSuite context=TestListIdsParams>:setup | `Error` | 0.00 | test_list_ids_parameter.py
test_delete_account | `Error` | 16.85 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 2.27 | test_network.py
test_delete_network_while_vm_on_it | `Error` | 2.28 | test_network.py
test_deploy_vm_l2network | `Error` | 2.27 | test_network.py
test_deploy_vm_l2network | `Error` | 2.28 | test_network.py
test_l2network_restart | `Error` | 2.38 | test_network.py
test_l2network_restart | `Error` | 2.38 | test_network.py
ContextSuite context=TestL2Networks>:teardown | `Error` | 3.48 | test_network.py
test_02_verifyRouterIpAfterNetworkRestart | `Failure` | 1.07 | test_network.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
test_01_secure_vm_migration | `Error` | 73.50 | test_vm_life_cycle.py
test_02_unsecure_vm_migration | `Error` | 216.81 | test_vm_life_cycle.py
test_03_secured_to_nonsecured_vm_migration | `Error` | 143.98 | test_vm_life_cycle.py
test_04_nonsecured_to_secured_vm_migration | `Error` | 144.14 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 1.74 | test_vm_life_cycle.py
test_network_acl | `Error` | 5.28 | test_network_acl.py
test_01_nic | `Error` | 49.49 | test_nic.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 1.76 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_02_routervm_iptables_policies | `Error` | 1.21 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 5.29 | test_routers_iptables_default_policy.py
test_01_VPC_nics_after_destroy | `Error` | 4.67 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Error` | 5.75 | test_vpc_router_nics.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 1.41 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 1.48 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Failure` | 15.44 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Failure` | 18.47 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Failure` | 29.53 | test_host_maintenance.py
ContextSuite context=TestHostMaintenanceAgents>:teardown | `Error` | 30.64 | test_host_maintenance.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan removed a comment on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan removed a comment on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025821055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] GutoVeronezi commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
GutoVeronezi commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r792739864
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
Review comment:
We could use `ByteScaleUtils` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017623668
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029917954
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029022604
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029061914
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2447
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025812788
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2406
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1026507144
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti merged pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti merged pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031212489
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031253526
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2492
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1016376515
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017231676
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798564655
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
Review comment:
@GutoVeronezi @DaanHoogland To use `ByteScaleUtils` new method(s) will need to be added. I feel we can do that in `main` in a separate PR and attempt to refactor similar occurrences across codebase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798564655
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
Review comment:
@GutoVeronezi @DaanHoogland To use `ByteScaleUtils` new method(s) will need to be added. I feel we can do that in `main` in a separate PR and attempt to refactor similar ocurrences
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028996412
Packaging result: :heavy_multiplication_x: el7 :heavy_multiplication_x: el8 :heavy_multiplication_x: debian :heavy_multiplication_x: suse15. SL-JID 2446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798559105
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
@sureshanaparti do we need to consider even ISO size for resource limit check done at line 3683? cc @DaanHoogland @rohityadavcloud @weizhouapache
I've made the change as VMs deployed using ISOs will always have root volume created from the specified disk offering and ISO size shouldn't be considered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028397330
<b>Trillian test result (tid-3121)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 45706 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5857-t3121-kvm-centos7.zip
Smoke tests completed. 91 look OK, 1 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3609.28 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 3610.33 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 0.07 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 0.04 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 0.03 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 89.01 | test_kubernetes_clusters.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028655785
@shwstppr Set config "storage.max.volume.size" to 10, and performed the following tests. Check tests not working as expected (marked in bold).
- Deployed VM with 8 GB disk [Passed, Works as expected]
- Deployed VM with 11 GB ROOT disk override [Failed, Works as expected]
**- Deployed VM with 9 GB ROOT disk and 3 GB Data Disk [Failed, Not working as expected, Cumulative size of ROOT and DATA disk are considered for validation, in this case it is comparing against 11 GB size]**
- Deployed VM with ISO, having 5 GB fixed disk offering [Passed, Works as expected]
**- Deployed VM with ISO, having 11 GB custom disk offering [Failed, Works as expected, but size in the error message is incorrect (Requested volume size is 14.99 GB, but the maximum size allowed is 10 GB)]**
**- Deployed VM with ISO, having 20 GB fixed disk offering [Failed, Works as expected, but size in the error message is incorrect (Requested volume size is 23.99 GB, but the maximum size allowed is 10 GB)]**
**- Deployed VM with ISO, having 9 GB custom disk offering [Failed, Not working as expected, Cumulative size of ISO - 3.99 GB and DATA disk are considered for validation, in this case it is comparing against 12.99 GB size (Requested volume size is 12.99 GB, but the maximum size allowed is 10 GB)]**
- Created Disk Offering with disk size 11 GB [Failed, Works as expected]
**- Created Compute Offering with ROOT disk size 11 GB [Passed, Not working as expected, Shouldn't allow]**
**- Deployed VM with Compute Offering having ROOT disk size 11 GB disk [Passed, Not working as expected, Shouldn't allow]**
- Create DATA volume with 20 GB fixed disk offering [Failed, Works as expected]
- Create DATA volume with 1 GB custom disk offering [Passed, Works as expected]
- Resize DATA volume of a running VM, from 9 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize ROOT volume of a running VM, from 8 GB to 11 GB [Failed, Works as expected]
- Resize ROOT volume of a running VM, from 8 GB to 10 GB [Passed, Works as expected]
- Resize DATA volume of a running VM, from 1 GB to 5 GB fixed disk offering [Passed, Works as expected]
- Resize DATA volume of a running VM, from 5 GB to 9 GB custom disk offering [Passed, Works as expected]
- Resize DATA volume of a running VM, from 9 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize DATA volume of a running VM, from 9 GB to 11 GB custom disk offering [Failed, Works as expected]
- Resize ROOT volume of a stopped VM, from 8 GB to 11 GB [Failed, Works as expected]
- Resize ROOT volume of a stopped VM, from 8 GB to 9 GB [Passed, Works as expected]
- Resize DATA volume of a stopped VM, 9 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize DATA volume of a stopped VM, 9 GB to 10 GB custom disk offering [Passed, Works as expected]
- Resize detached DATA volume, from 5 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize detached DATA volume, from 5 GB to 7 GB custom disk offering [Passed, Works as expected]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1027013449
<b>Trillian test result (tid-3091)</b>
Environment: kvm-centos7 (x2), Advanced Networking with Mgmt server 7
Total time taken: 34721 seconds
Marvin logs: https://github.com/blueorangutan/acs-prs/releases/download/trillian/pr5857-t3091-kvm-centos7.zip
Smoke tests completed. 71 look OK, 21 have errors
Only failed tests results shown below:
Test | Result | Time (s) | Test File
--- | --- | --- | ---
test_02_deploy_vm_from_direct_download_template | `Error` | 1.19 | test_templates.py
ContextSuite context=TestTemplates>:setup | `Error` | 17.80 | test_templates.py
ContextSuite context=TestRemoteDiagnostics>:setup | `Error` | 0.00 | test_diagnostics.py
test_01_deploy_vm_from_direct_download_template_nfs_storage | `Error` | 1.20 | test_direct_download.py
ContextSuite context=TestDirectDownloadTemplates>:teardown | `Error` | 1.08 | test_direct_download.py
test_01_add_primary_storage_disabled_host | `Error` | 0.57 | test_primary_storage.py
test_01_primary_storage_nfs | `Error` | 0.10 | test_primary_storage.py
ContextSuite context=TestStorageTags>:setup | `Error` | 0.19 | test_primary_storage.py
test_01_vpc_privategw_acl | `Failure` | 5.69 | test_privategw_acl.py
test_02_vpc_privategw_static_routes | `Failure` | 6.66 | test_privategw_acl.py
test_03_vpc_privategw_restart_vpc_cleanup | `Failure` | 5.63 | test_privategw_acl.py
test_04_rvpc_privategw_static_routes | `Failure` | 7.70 | test_privategw_acl.py
ContextSuite context=TestLBRuleUsage>:setup | `Error` | 3.79 | test_usage.py
ContextSuite context=TestNatRuleUsage>:setup | `Error` | 5.42 | test_usage.py
ContextSuite context=TestPublicIPUsage>:setup | `Error` | 7.05 | test_usage.py
ContextSuite context=TestResetVmOnReboot>:setup | `Error` | 0.00 | test_reset_vm_on_reboot.py
test_01_so_removal_resource_update | `Error` | 1.31 | test_resource_accounting.py
test_01_create_delete_portforwarding_fornonvpc | `Error` | 1.79 | test_portforwardingrules.py
test_03_deploy_vm_domain_service_offering | `Error` | 8.16 | test_domain_service_offerings.py
test_03_create_vpc_domain_vpc_offering | `Error` | 6.04 | test_domain_vpc_offerings.py
test_01_invalid_upgrade_kubernetes_cluster | `Failure` | 3606.10 | test_kubernetes_clusters.py
test_02_upgrade_kubernetes_cluster | `Failure` | 71.58 | test_kubernetes_clusters.py
test_03_deploy_and_scale_kubernetes_cluster | `Failure` | 44.03 | test_kubernetes_clusters.py
test_04_autoscale_kubernetes_cluster | `Failure` | 4.24 | test_kubernetes_clusters.py
test_05_basic_lifecycle_kubernetes_cluster | `Failure` | 4.21 | test_kubernetes_clusters.py
test_06_delete_kubernetes_cluster | `Failure` | 4.21 | test_kubernetes_clusters.py
test_07_deploy_kubernetes_ha_cluster | `Failure` | 3.20 | test_kubernetes_clusters.py
test_08_upgrade_kubernetes_ha_cluster | `Failure` | 4.24 | test_kubernetes_clusters.py
test_09_delete_kubernetes_ha_cluster | `Failure` | 4.20 | test_kubernetes_clusters.py
ContextSuite context=TestKubernetesCluster>:teardown | `Error` | 101.63 | test_kubernetes_clusters.py
ContextSuite context=TestDeployVM>:setup | `Error` | 0.00 | test_vm_life_cycle.py
ContextSuite context=TestVMLifeCycle>:setup | `Error` | 1.68 | test_vm_life_cycle.py
test_network_acl | `Error` | 5.26 | test_network_acl.py
test_01_nic | `Error` | 49.36 | test_nic.py
ContextSuite context=TestCpuCapServiceOfferings>:setup | `Error` | 0.00 | test_service_offerings.py
ContextSuite context=TestServiceOfferings>:setup | `Error` | 1.82 | test_service_offerings.py
ContextSuite context=TestSnapshotRootDisk>:setup | `Error` | 0.00 | test_snapshots.py
test_02_routervm_iptables_policies | `Error` | 1.21 | test_routers_iptables_default_policy.py
test_01_single_VPC_iptables_policies | `Error` | 6.34 | test_routers_iptables_default_policy.py
test_01_VPC_nics_after_destroy | `Error` | 5.65 | test_vpc_router_nics.py
test_02_VPC_default_routes | `Error` | 6.68 | test_vpc_router_nics.py
test_01_cancel_host_maintenace_with_no_migration_jobs | `Error` | 0.04 | test_host_maintenance.py
test_02_cancel_host_maintenace_with_migration_jobs | `Error` | 0.04 | test_host_maintenance.py
test_03_cancel_host_maintenace_with_migration_jobs_failure | `Error` | 0.04 | test_host_maintenance.py
test_01_cancel_host_maintenance_ssh_enabled_agent_connected | `Error` | 0.01 | test_host_maintenance.py
test_03_cancel_host_maintenance_ssh_disabled_agent_connected | `Error` | 0.01 | test_host_maintenance.py
test_04_cancel_host_maintenance_ssh_disabled_agent_disconnected | `Error` | 0.01 | test_host_maintenance.py
test_hostha_enable_ha_when_host_in_maintenance | `Error` | 303.73 | test_hostha_kvm.py
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1025817870
@blueorangutan test keepEnv
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028643284
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2442
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028680824
@sureshanaparti I don't think the config applies to cumulative VM volume size. In my understanding it is for individual volumes.
I'll check and update for offering's root disk size and size mismatch in error message
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028990137
@shwstppr a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028989365
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798583477
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
I'm not completely sure if ISO will be copied to primary store. But even if is and if the same ISO is used by 10 accounts to deploy a VM each, the operator will end up charging them all for ISO size.
Better for now, leave it as it is, too big a change for 4.16.1 :D I'm reverting it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr removed a comment on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr removed a comment on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028989365
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029021641
@blueorangutan package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029974343
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029945776
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2454
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r797497720
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
+ throw new InvalidParameterValueException(String.format("Requested volume size is %d, but the maximum size allowed is %d GB.", size, maxVolumeSize));
Review comment:
> @sureshanaparti I've made the change to fix this.
> I see you've started a new test run. I don't think this change affects results. Up to you.
if not further changes, would upgrade the package and verify this log.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028625926
@sureshanaparti a Jenkins job has been kicked to build packages. I'll keep you posted as I make progress.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti edited a comment on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti edited a comment on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1028655785
@shwstppr Set config "storage.max.volume.size" to 10, and performed the following tests. Check tests not working as expected (marked in bold).
- Deployed VM with 8 GB disk [Passed, Works as expected]
- Deployed VM with 11 GB ROOT disk override [Failed, Works as expected]
- **Deployed VM with 9 GB ROOT disk and 3 GB Data Disk [Failed, Not working as expected, Cumulative size of ROOT and DATA disk are considered for validation, in this case it is comparing against 11 GB size]**
- Deployed VM with ISO, having 5 GB fixed disk offering [Passed, Works as expected]
- **Deployed VM with ISO, having 11 GB custom disk offering [Failed, Works as expected, but size in the error message is incorrect (Requested volume size is 14.99 GB, but the maximum size allowed is 10 GB)]**
- **Deployed VM with ISO, having 20 GB fixed disk offering [Failed, Works as expected, but size in the error message is incorrect (Requested volume size is 23.99 GB, but the maximum size allowed is 10 GB)]**
- **Deployed VM with ISO, having 9 GB custom disk offering [Failed, Not working as expected, Cumulative size of ISO - 3.99 GB and DATA disk are considered for validation, in this case it is comparing against 12.99 GB size (Requested volume size is 12.99 GB, but the maximum size allowed is 10 GB)]**
- Created Disk Offering with disk size 11 GB [Failed, Works as expected]
- **Created Compute Offering with ROOT disk size 11 GB [Passed, Not working as expected, Shouldn't allow]**
- **Deployed VM with Compute Offering having ROOT disk size 11 GB disk [Passed, Not working as expected, Shouldn't allow]**
- Create DATA volume with 20 GB fixed disk offering [Failed, Works as expected]
- Create DATA volume with 1 GB custom disk offering [Passed, Works as expected]
- Resize DATA volume of a running VM, from 9 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize ROOT volume of a running VM, from 8 GB to 11 GB [Failed, Works as expected]
- Resize ROOT volume of a running VM, from 8 GB to 10 GB [Passed, Works as expected]
- Resize DATA volume of a running VM, from 1 GB to 5 GB fixed disk offering [Passed, Works as expected]
- Resize DATA volume of a running VM, from 5 GB to 9 GB custom disk offering [Passed, Works as expected]
- Resize DATA volume of a running VM, from 9 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize DATA volume of a running VM, from 9 GB to 11 GB custom disk offering [Failed, Works as expected]
- Resize ROOT volume of a stopped VM, from 8 GB to 11 GB [Failed, Works as expected]
- Resize ROOT volume of a stopped VM, from 8 GB to 9 GB [Passed, Works as expected]
- Resize DATA volume of a stopped VM, 9 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize DATA volume of a stopped VM, 9 GB to 10 GB custom disk offering [Passed, Works as expected]
- Resize detached DATA volume, from 5 GB to 20 GB fixed disk offering [Failed, Works as expected]
- Resize detached DATA volume, from 5 GB to 7 GB custom disk offering [Passed, Works as expected]
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r798559105
##########
File path: server/src/main/java/com/cloud/vm/UserVmManagerImpl.java
##########
@@ -3831,11 +3830,15 @@ private UserVm createVirtualMachine(DataCenter zone, ServiceOffering serviceOffe
// check if account/domain is with in resource limits to create a new vm
boolean isIso = Storage.ImageFormat.ISO == template.getFormat();
- long size = configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
+ long volumesSize = isIso ? 0 : configureCustomRootDiskSize(customParameters, template, hypervisorType, offering);
Review comment:
@sureshanaparti do we need to consider even ISO size for resource limit check done at line 3683? cc @DaanHoogland @rohityadavcloud @weizhouapache
I've made the change as volume VMs deployed using ISOs will always have root volume created from the specified disk offering and ISO size shouldn't be considered
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029094688
@sureshanaparti a Trillian-Jenkins test job (centos7 mgmt + kvm-centos7) has been kicked to run smoke tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1017539998
Can you rebase to solve the conflicts, @shwstppr ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r797337104
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
+ throw new InvalidParameterValueException(String.format("Requested volume size is %d, but the maximum size allowed is %d GB.", size, maxVolumeSize));
Review comment:
@shwstppr Can you update the log so that both the sizes are in sync with the units. For ex:
_Requested volume size is 21474836480, but the maximum size allowed is 15 GB._ => `Requested volume size is 20 GB, but the maximum size allowed is 15 GB.`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on a change in pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on a change in pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#discussion_r797570676
##########
File path: server/src/main/java/com/cloud/storage/VolumeApiServiceImpl.java
##########
@@ -856,11 +855,13 @@ public VolumeVO doInTransaction(TransactionStatus status) {
});
}
+ @Override
public boolean validateVolumeSizeRange(long size) {
+ long maxVolumeSize = VolumeOrchestrationService.MaxVolumeSize.value();
if (size < 0 || (size > 0 && size < (1024 * 1024 * 1024))) {
throw new InvalidParameterValueException("Please specify a size of at least 1 GB.");
- } else if (size > (_maxVolumeSizeInGb * 1024 * 1024 * 1024)) {
- throw new InvalidParameterValueException("Requested volume size is " + size + ", but the maximum size allowed is " + _maxVolumeSizeInGb + " GB.");
+ } else if (size > (maxVolumeSize * 1024 * 1024 * 1024)) {
Review comment:
the specific conversion must be added in that class first. But I agree with the suggestion.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029903287
> @sureshanaparti I don't think the config applies to cumulative VM volume size. In my understanding it is for individual volumes.
> I'll check and update for offering's root disk size and size mismatch in error message
@shwstppr Verified the cases not working as expected, with the latest changes. Invalid error message in one case, check below.
- Deployed VM with 9 GB ROOT disk and 3 GB Data Disk [Passd, Working as expected]
- Deployed VM with ISO, having 11 GB custom disk offering [Failed, Works as expected]
- Deployed VM with ISO, having 20 GB fixed disk offering [Failed, Works as expected]
- Deployed VM with ISO, having 9 GB custom disk offering [Passed, Working as expected]
- Created Compute Offering with ROOT disk size 11 GB [Failed, Working as expected]
**- Deployed VM with Compute Offering having ROOT disk size 11 GB disk [Failed, Working as expected, But wrong error message - Please specify a size of at least 1 GB.]**
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] blueorangutan commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1031163261
Packaging result: :heavy_check_mark: el7 :heavy_check_mark: el8 :heavy_check_mark: debian :heavy_check_mark: suse15. SL-JID 2486
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] shwstppr commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
shwstppr commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1011965323
@harikrishna-patnala I've made changes and ensured the config is respected during VM deployment, volume creation and volume resize. Also, to fix its dynamic behaviour.
Currently, the config affects even root admin vm and volume deployment. Also, I've purposefully not included check for root disk size when it is taken directly from the template. Can you please have an initial look at the changes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] sureshanaparti commented on pull request #5857: server,config: respect storage.max.volume.size and make it dynamic
Posted by GitBox <gi...@apache.org>.
sureshanaparti commented on pull request #5857:
URL: https://github.com/apache/cloudstack/pull/5857#issuecomment-1029973766
@blueorangutan test
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org