You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by omefire <gi...@git.apache.org> on 2016/02/27 00:15:33 UTC
[GitHub] cordova-plugin-camera pull request: CB-10711: getPicture() should ...
GitHub user omefire opened a pull request:
https://github.com/apache/cordova-plugin-camera/pull/181
CB-10711: getPicture() should NOT save to photo album when called wit…
…h destinationType set Camera.DestinationType.NATIVE_URI
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/omefire/cordova-plugin-camera CB-10711
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-plugin-camera/pull/181.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #181
----
commit f929f31d4dccb8e875e290ca77f829f7bab07089
Author: Omar Mefire <om...@gmail.com>
Date: 2016-02-26T23:13:09Z
CB-10711: getPicture() should NOT save to photo album when called with destinationType set Camera.DestinationType.NATIVE_URI
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10711: getPicture() should ...
Posted by omefire <gi...@git.apache.org>.
Github user omefire commented on the pull request:
https://github.com/apache/cordova-plugin-camera/pull/181#issuecomment-189526888
I just realized that unless the image is saved to the photo album, we won't be able to have a native URI for iOS(ms-assets://).
So, I'll change this PR to have a comment to document this limitation.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-plugin-camera pull request: CB-10711: getPicture() should ...
Posted by omefire <gi...@git.apache.org>.
Github user omefire closed the pull request at:
https://github.com/apache/cordova-plugin-camera/pull/181
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org