You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/03/04 11:22:48 UTC
[GitHub] [airflow] caxefaizan opened a new pull request #21990: missing quotes
caxefaizan opened a new pull request #21990:
URL: https://github.com/apache/airflow/pull/21990
Missing quotes throws the following error:
```
airflow:
- env.0.value: Invalid type. Expected: string, given: boolean
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060598244
> Any other proposal? Is that one good now?
@potiuk found it.
```
--set-string "env[0].name=AIRFLOW__CORE__LOAD_EXAMPLES" \
--set-string "env[0].value=True" \
```
does the trick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan removed a comment on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan removed a comment on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060137312
> Any other proposal? Is that one good now?
@potiuk Nope. it didn't work. I used values.yaml to apply these values. using the `-f values.yaml` tag
```
#values.yaml
extraEnv: |
- name: AIRFLOW__CORE__LOAD_EXAMPLES
value: 'True'
```
I believe we should change this to an issue then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059261424
shouldn't merge yet.
it still is erroring out after adding quotes.
airflow.exceptions.AirflowConfigException: Failed to convert value to bool. Please check "LOAD_EXAMPLES" key in "core" section. Current value: "'true'".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060137312
> Any other proposal? Is that one good now?
@potiuk Nope. it didn't work. I used values.yaml to apply these values. I believe we should change this to an issue then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan edited a comment on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan edited a comment on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060598244
> Any other proposal? Is that one good now?
@potiuk found it.
```
--set-string "env[0].name=AIRFLOW__CORE__LOAD_EXAMPLES" \
--set-string "env[0].value=True"
```
does the trick. tested as well.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059408977
> Should be lowercase true I think
tried using lower case. didn't work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan edited a comment on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan edited a comment on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060598244
> Any other proposal? Is that one good now?
@potiuk found it.
```
--set-string "env[0].name=AIRFLOW__CORE__LOAD_EXAMPLES" \
--set-string "env[0].value=True"
```
does the trick
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan edited a comment on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan edited a comment on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060137312
> Any other proposal? Is that one good now?
@potiuk Nope. it didn't work. I used values.yaml to apply these values. using the `-f values.yaml` tag
```
#values.yaml
extraEnv: |
- name: AIRFLOW__CORE__LOAD_EXAMPLES
value: 'True'
```
I believe we should change this to an issue then?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059406985
The PR is likely ready to be merged. No tests are needed as no important environment files, nor python files were modified by it. However, committers might decide that full test matrix is needed and add the 'full tests needed' label. Then you should rebase it to the latest main or amend the last commit of the PR, and push it with --force-with-lease.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1060106195
Any other proposal? Is that one good now?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #21990:
URL: https://github.com/apache/airflow/pull/21990
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] caxefaizan edited a comment on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
caxefaizan edited a comment on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059408977
> Should be lowercase true I think
tried using lower case. didn't work. with and without quotes
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #21990: missing quotes
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #21990:
URL: https://github.com/apache/airflow/pull/21990#issuecomment-1059405965
Should be lowercase true I think
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org