You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@cordova.apache.org by GitBox <gi...@apache.org> on 2020/06/10 06:27:58 UTC
[GitHub] [cordova-ios] dpogue opened a new pull request #896: Set the background colour as an xcasset color set
dpogue opened a new pull request #896:
URL: https://github.com/apache/cordova-ios/pull/896
# Platforms affected
iOS
### Motivation and Context
Resolves #890 where the splashscreen UIView defaults to a transparent background if no `BackgroundColor` preference is specified in config.xml.
### Description
Add a named color set to Images.xcassets named `BackgroundColor` which defaults to the system background colour (respecting dark mode). On prepare, it will be set to the value specified in config.xml. Set the LaunchScreen Storyboard to use that as the background colour, and also ensure the WebView and SplashScreen UIView also use it as the background colour.
This also hypothetically opens the door for people to (via `<resource-file>` tags) provide their own color set content with different values for different devices or different light/dark modes. Caveat that this is not in the realm of supported Cordova behaviour, and we do not make any guarantees about this working.
If you're embedding the Cordova ViewController in another app or otherwise don't have a `BackgroundColor` color set in xcassets, it will fallback to white.
### Testing
<!-- Please describe in detail how you tested your changes. -->
* Manual testing against a simulator.
* Added spec tests for the `BackgroundColor` preference parsing in prepare.spec.js
### Checklist
- [x] I've run the tests to see all new and existing tests pass
- [x] I added automated test coverage as appropriate for this change
- [x] If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct [keyword to close issues using keywords](https://help.github.com/articles/closing-issues-using-keywords/))
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue merged pull request #896: Set the background colour as an xcasset color set
Posted by GitBox <gi...@apache.org>.
dpogue merged pull request #896:
URL: https://github.com/apache/cordova-ios/pull/896
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] codecov-commenter commented on pull request #896: Set the background colour as an xcasset color set
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #896:
URL: https://github.com/apache/cordova-ios/pull/896#issuecomment-642356370
# [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=h1) Report
> Merging [#896](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-ios/commit/062b91dc965c9638f1b65cb18e3898bd81cd7261&el=desc) will **increase** coverage by `0.08%`.
> The diff coverage is `78.37%`.
[](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #896 +/- ##
==========================================
+ Coverage 74.40% 74.48% +0.08%
==========================================
Files 13 13
Lines 1676 1713 +37
==========================================
+ Hits 1247 1276 +29
- Misses 429 437 +8
```
| [Impacted Files](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [bin/templates/scripts/cordova/lib/prepare.js](https://codecov.io/gh/apache/cordova-ios/pull/896/diff?src=pr&el=tree#diff-YmluL3RlbXBsYXRlcy9zY3JpcHRzL2NvcmRvdmEvbGliL3ByZXBhcmUuanM=) | `84.78% <78.37%> (-0.63%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=footer). Last update [062b91d...9b3e078](https://codecov.io/gh/apache/cordova-ios/pull/896?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org
[GitHub] [cordova-ios] dpogue commented on pull request #896: Set the background colour as an xcasset color set
Posted by GitBox <gi...@apache.org>.
dpogue commented on pull request #896:
URL: https://github.com/apache/cordova-ios/pull/896#issuecomment-642356872
@erisu Thanks for catching that. I've fixed the missing test fixture, and also added a second commit to address the SplashScreen being blank. It should work as intended now 😁
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org