[jira] [Commented] (NIFI-5491) PutHive3Streaming incorrectly handles bytes, shorts, and nested structs

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/NIFI-5491?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570531#comment-16570531 ] 

ASF GitHub Bot commented on NIFI-5491:
--------------------------------------

GitHub user mattyb149 opened a pull request:

    https://github.com/apache/nifi/pull/2938

    NIFI-5491: Fixed PutHive3Streaming handling of Byte, Short, and Struct

    Thank you for submitting a contribution to Apache NiFi.
    
    In order to streamline the review of the contribution we ask you
    to ensure the following steps have been taken:
    
    ### For all changes:
    - [x] Is there a JIRA ticket associated with this PR? Is it referenced 
         in the commit message?
    
    - [x] Does your PR title start with NIFI-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
    
    - [x] Has your PR been rebased against the latest commit within the target branch (typically master)?
    
    - [x] Is your initial contribution a single, squashed commit?
    
    ### For code changes:
    - [x] Have you ensured that the full suite of tests is executed via mvn -Pcontrib-check clean install at the root nifi folder?
    - [x] Have you written or updated unit tests to verify your changes?
    - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? 
    - [ ] If applicable, have you updated the LICENSE file, including the main LICENSE file under nifi-assembly?
    - [ ] If applicable, have you updated the NOTICE file, including the main NOTICE file found under nifi-assembly?
    - [ ] If adding new Properties, have you added .displayName in addition to .name (programmatic access) for each of the new properties?
    
    ### For documentation related changes:
    - [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
    
    ### Note:
    Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mattyb149/nifi NIFI-5491

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/nifi/pull/2938.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2938
    
----
commit 68f83ac1e2987e008c6b5ef7d5fcf6e18cc21c0c
Author: Matthew Burgess <ma...@...>
Date:   2018-08-06T17:34:39Z

    NIFI-5491: Fixed PutHive3Streaming handling of Byte, Short, and Struct

----


> PutHive3Streaming incorrectly handles bytes, shorts, and nested structs
> -----------------------------------------------------------------------
>
>                 Key: NIFI-5491
>                 URL: https://issues.apache.org/jira/browse/NIFI-5491
>             Project: Apache NiFi
>          Issue Type: Bug
>          Components: Extensions
>            Reporter: Matt Burgess
>            Assignee: Matt Burgess
>            Priority: Major
>
> When trying to insert a record into a Hive table using PutHive3Streaming, if the table contains columns of types byte, short, or struct, then an error occurs and the records cannot be written.
> This is due to a mismatch between the data types used in the NiFi Record API and the Hive ORC writer and StructObjectInspector. For byte and short, NiFi currently maintains an Integer value but Hive expects a Byte or Short, respectively. For structs, NiFi maintains a Map value but Hive expects a List or array.
> NiFiRecordSerDe should handle the conversion of values for use by Hive Streaming.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)