You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by GitBox <gi...@apache.org> on 2022/09/09 19:50:16 UTC

[GitHub] [phoenix-omid] gjacoby126 opened a new pull request, #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

gjacoby126 opened a new pull request, #123:
URL: https://github.com/apache/phoenix-omid/pull/123

   …ependencies
   
   At some point OMID will upgrade to latest Hadoop 2.10 and HBase 2.4 releases and will then experience IncompatibleClassChangeErrors in unit tests due to a conflict between mockito-all used here and mockito-core used by Hadoop and HBase. Prepare for this by migrating from mockito-all to mockito-core now.
   
   Update matchers in some unit tests for minor differences in mocking and matching behavior after the migration.
   
   Clean up test dependency declarations in POMs while at it.
   
   Phoenix itself should perform this migration as well.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] gjacoby126 commented on pull request #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on PR #123:
URL: https://github.com/apache/phoenix-omid/pull/123#issuecomment-1254228520

   I still can't recreate the issue with TestWorldTimeOracle.testTimestampOraclePanicsWhenTheStorageHasProblems locally, and the code looks fine. I reordered the mock setup to be before component initialization in case there was a race condition. In addition, the extra thread calling next() on the oracle didn't seem necessary so I removed it, which sped up the test. 
   
   Let's see again if that improves things in TravisCI. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] stoty commented on pull request #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

Posted by GitBox <gi...@apache.org>.
stoty commented on PR #123:
URL: https://github.com/apache/phoenix-omid/pull/123#issuecomment-1253247868

   @gjacoby126 Were you able to make progess on this ?
   This is the only remaining issue before releasing the next version.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] gjacoby126 commented on pull request #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on PR #123:
URL: https://github.com/apache/phoenix-omid/pull/123#issuecomment-1242398910

   I cloned @apurtell 's OMID-226 PR to rebase it on the current OMID head, and see if I could figure out why a few tests were failing. To my surprise after the rebase all tests passed for me locally -- let's see what TravisCI does. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] stoty commented on pull request #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

Posted by GitBox <gi...@apache.org>.
stoty commented on PR #123:
URL: https://github.com/apache/phoenix-omid/pull/123#issuecomment-1243442005

   The tests have passed locally for me, too.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] gjacoby126 merged pull request #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

Posted by GitBox <gi...@apache.org>.
gjacoby126 merged PR #123:
URL: https://github.com/apache/phoenix-omid/pull/123


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [phoenix-omid] gjacoby126 commented on pull request #123: OMID-226 Migrate from mockito-all to mockito-core and clean up test d…

Posted by GitBox <gi...@apache.org>.
gjacoby126 commented on PR #123:
URL: https://github.com/apache/phoenix-omid/pull/123#issuecomment-1254399244

   @stoty - looks like it's passing now. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org