[GitHub] [incubator-pinot] chenboat commented on a change in pull request #4825: Bug Fix: Fix segment download url in SegmentZkMetadata.

[GitBox <gi...@apache.org>]

chenboat commented on a change in pull request #4825: Bug Fix: Fix segment download url in SegmentZkMetadata.
URL: https://github.com/apache/incubator-pinot/pull/4825#discussion_r346522276
 
 

 ##########
 File path: pinot-controller/src/main/java/org/apache/pinot/controller/api/resources/PinotSegmentUploadRestletResource.java
 ##########
 @@ -352,10 +352,10 @@ private String getZkDownloadURIForSegmentUpload(FileUploadPathProvider provider,
     if (baseDataDirURI.getScheme().equalsIgnoreCase(CommonConstants.Segment.LOCAL_SEGMENT_SCHEME)) {
       return URIUtils.constructDownloadUrl(provider.getVip(), rawTableName, segmentName);
     } else {
-      // Receiving .tar.gz segment upload for pluggable storage
-      LOGGER.info("Using configured data dir {} for segment {} of table {}", _controllerConf.getDataDir(), segmentName,
-          rawTableName);
-      return URIUtils.constructDownloadUrl(baseDataDirURI.toString(), rawTableName, segmentName);
+      // Receiving .tar.gz segment upload for pluggable storage. Download URI is the same as final segment location.
 
 Review comment:
   final segment location -> deep store URI or segment store URI to make it clearer? The word final sounds a bit vague to me.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org