You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/01/23 06:59:26 UTC
[GitHub] [rocketmq] xujianhai666 opened a new pull request #1742: [ISSUE
#1741]feat(client): rename takeMessags to takeMessages
xujianhai666 opened a new pull request #1742: [ISSUE #1741]feat(client): rename takeMessags to takeMessages
URL: https://github.com/apache/rocketmq/pull/1742
What is the purpose of the change
## Brief changelog
## Verifying this change
Follow this checklist to help us incorporate your contribution quickly and easily. Notice, `it would be helpful if you could finish the following 5 checklist(the last one is not necessary)before request the community to review your PR`.
- [x] Make sure there is a [Github issue](https://github.com/apache/rocketmq/issues) filed for the change (usually before you start working on it). Trivial changes like typos do not require a Github issue. Your pull request should address just this issue, without pulling in other changes - one PR resolves one issue.
- [x] Format the pull request title like `[ISSUE #123] Fix UnknownException when host config not exist`. Each commit in the pull request should have a meaningful subject line and body.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Write necessary unit-test(over 80% coverage) to verify your logic correction, more mock a little better when cross module dependency exist. If the new feature or significant change is committed, please remember to add integration-test in [test module](https://github.com/apache/rocketmq/tree/master/test).
- [x] Run `mvn -B clean apache-rat:check findbugs:findbugs checkstyle:checkstyle` to make sure basic checks pass. Run `mvn clean install -DskipITs` to make sure unit-test pass. Run `mvn clean test-compile failsafe:integration-test` to make sure integration-test pass.
- [ ] If this contribution is large, please file an [Apache Individual Contributor License Agreement](http://www.apache.org/licenses/#clas).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] duhenglucky commented on issue #1742: [ISSUE
#1741]feat(client): rename takeMessags to takeMessages
Posted by GitBox <gi...@apache.org>.
duhenglucky commented on issue #1742: [ISSUE #1741]feat(client): rename takeMessags to takeMessages
URL: https://github.com/apache/rocketmq/pull/1742#issuecomment-578496545
@xujianhai666 it would be nice if you can pull request to the develop branch :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] ShannonDing merged pull request #1742: [ISSUE
#1741]feat(client): rename takeMessags to takeMessages
Posted by GitBox <gi...@apache.org>.
ShannonDing merged pull request #1742: [ISSUE #1741]feat(client): rename takeMessags to takeMessages
URL: https://github.com/apache/rocketmq/pull/1742
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] xujianhai666 commented on issue #1742: [ISSUE
#1741]feat(client): rename takeMessags to takeMessages
Posted by GitBox <gi...@apache.org>.
xujianhai666 commented on issue #1742: [ISSUE #1741]feat(client): rename takeMessags to takeMessages
URL: https://github.com/apache/rocketmq/pull/1742#issuecomment-578619329
> @xujianhai666 it would be nice if you can pull request to the develop branch :).
@duhenglucky thx for ur chang
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [rocketmq] coveralls commented on issue #1742: [ISSUE
#1741]feat(client): rename takeMessags to takeMessages
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #1742: [ISSUE #1741]feat(client): rename takeMessags to takeMessages
URL: https://github.com/apache/rocketmq/pull/1742#issuecomment-577538105
[](https://coveralls.io/builds/28276145)
Coverage decreased (-0.02%) to 50.574% when pulling **c73ee3ef3e4680dce2fab96441cbc304702bacc6 on xujianhai666:feat-rename-takemessages** into **c8892e1bf4e594f1b2480065a4b956eb32ae20f6 on apache:master**.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services