You are viewing a plain text version of this content. The canonical link for it is here.
Posted to fop-commits@xmlgraphics.apache.org by ma...@apache.org on 2008/05/31 13:45:55 UTC

svn commit: r662009 - /xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java

Author: maxberger
Date: Sat May 31 04:45:55 2008
New Revision: 662009

URL: http://svn.apache.org/viewvc?rev=662009&view=rev
Log:
Code Cleanups (no functional change)

Modified:
    xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java

Modified: xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java
URL: http://svn.apache.org/viewvc/xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java?rev=662009&r1=662008&r2=662009&view=diff
==============================================================================
--- xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java (original)
+++ xmlgraphics/fop/trunk/src/java/org/apache/fop/layoutmgr/inline/TextLayoutManager.java Sat May 31 04:45:55 2008
@@ -5,9 +5,9 @@
  * The ASF licenses this file to You under the Apache License, Version 2.0
  * (the "License"); you may not use this file except in compliance with
  * the License.  You may obtain a copy of the License at
- * 
+ *
  *      http://www.apache.org/licenses/LICENSE-2.0
- * 
+ *
  * Unless required by applicable law or agreed to in writing, software
  * distributed under the License is distributed on an "AS IS" BASIS,
  * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
@@ -31,9 +31,7 @@
 import org.apache.fop.fo.Constants;
 import org.apache.fop.fo.FOText;
 import org.apache.fop.fonts.Font;
-import org.apache.fop.fonts.FontInfo;
 import org.apache.fop.fonts.FontSelector;
-import org.apache.fop.fonts.FontTriplet;
 import org.apache.fop.layoutmgr.InlineKnuthSequence;
 import org.apache.fop.layoutmgr.KnuthBox;
 import org.apache.fop.layoutmgr.KnuthElement;
@@ -63,25 +61,25 @@
      * Number of word-spaces?
      */
     private class AreaInfo {
-        private short startIndex;
-        private short breakIndex;
-        private short wordSpaceCount;
+        private final short startIndex;
+        private final short breakIndex;
+        private final short wordSpaceCount;
         private short letterSpaceCount;
-        private MinOptMax areaIPD;
-        private boolean isHyphenated;
-        private boolean isSpace;
+        private final MinOptMax areaIPD;
+        private final boolean isHyphenated;
+        private final boolean isSpace;
         private boolean breakOppAfter;
         private final Font font;
 
-        AreaInfo(short startIndex,
-                        short breakIndex,
-                        short wordSpaceCount,
-                        short letterSpaceCount,
-                        MinOptMax areaIPD,
-                        boolean isHyphenated,
-                        boolean isSpace,
-                        boolean breakOppAfter,
-                        Font font) {
+        AreaInfo(final short startIndex,
+                        final short breakIndex,
+                        final short wordSpaceCount,
+                        final short letterSpaceCount,
+                        final MinOptMax areaIPD,
+                        final boolean isHyphenated,
+                        final boolean isSpace,
+                        final boolean breakOppAfter,
+                        final Font font) {
             this.startIndex = startIndex;
             this.breakIndex = breakIndex;
             this.wordSpaceCount = wordSpaceCount;
@@ -94,14 +92,14 @@
         }
 
         public String toString() {
-            return "[ lscnt=" + letterSpaceCount
-                + ", wscnt=" + wordSpaceCount
-                + ", ipd=" + areaIPD.toString()
-                + ", sidx=" + startIndex
-                + ", bidx=" + breakIndex
-                + ", hyph=" + isHyphenated
-                + ", space=" + isSpace
-                + ", font=" + font
+            return "[ lscnt=" + this.letterSpaceCount
+                + ", wscnt=" + this.wordSpaceCount
+                + ", ipd=" + this.areaIPD.toString()
+                + ", sidx=" + this.startIndex
+                + ", bidx=" + this.breakIndex
+                + ", hyph=" + this.isHyphenated
+                + ", space=" + this.isSpace
+                + ", font=" + this.font
                 + "]";
         }
 
@@ -109,11 +107,11 @@
 
     // this class stores information about changes in vecAreaInfo
     // which are not yet applied
-    private class PendingChange {
-        public AreaInfo ai;
-        public int index;
+    private final class PendingChange {
+        private final AreaInfo ai;
+        private final int index;
 
-        public PendingChange(AreaInfo ai, int index) {
+        private PendingChange(final AreaInfo ai, final int index) {
             this.ai = ai;
             this.index = index;
         }
@@ -122,10 +120,10 @@
     /**
      * logging instance
      */
-    private static Log log = LogFactory.getLog(TextLayoutManager.class);
+    private static final Log LOG = LogFactory.getLog(TextLayoutManager.class);
 
     // Hold all possible breaks for the text in this LM's FO.
-    private ArrayList vecAreaInfo;
+    private final List vecAreaInfo;
 
     /** Non-space characters on which we can end a line. */
     private static final String BREAK_CHARS = "-/";
@@ -133,14 +131,14 @@
     /** Used to reduce instantiation of MinOptMax with zero length. Do not modify! */
     private static final MinOptMax ZERO_MINOPTMAX = new MinOptMax(0);
 
-    private FOText foText;
-    private char[] textArray;
+    private final FOText foText;
+    private final char[] textArray;
     /**
      * Contains an array of widths to adjust for kerning. The first entry can
      * be used to influence the start position of the first letter. The entry i+1 defines the
      * cursor advancement after the character i. A null entry means no special advancement.
      */
-    private MinOptMax[] letterAdjustArray; //size = textArray.length + 1
+    private final MinOptMax[] letterAdjustArray; //size = textArray.length + 1
 
     private static final char NEWLINE = '\n';
 
@@ -161,7 +159,7 @@
     private int returnedIndex = 0;
     private short thisStart = 0;
     private short tempStart = 0;
-    private LinkedList changeList = null;
+    private List changeList = null;
 
     private AlignmentContext alignmentContext = null;
 
@@ -177,24 +175,24 @@
      *
      * @param node The FOText object to be rendered
      */
-    public TextLayoutManager(FOText node) {
+    public TextLayoutManager(final FOText node) {
         super();
-        foText = node;
+        this.foText = node;
 
-        textArray = new char[node.endIndex - node.startIndex];
-        System.arraycopy(node.ca, node.startIndex, textArray, 0,
+        this.textArray = new char[node.endIndex - node.startIndex];
+        System.arraycopy(node.ca, node.startIndex, this.textArray, 0,
             node.endIndex - node.startIndex);
-        letterAdjustArray = new MinOptMax[textArray.length + 1];
+        this.letterAdjustArray = new MinOptMax[this.textArray.length + 1];
 
-        vecAreaInfo = new java.util.ArrayList();
+        this.vecAreaInfo = new java.util.ArrayList();
     }
 
-    private KnuthPenalty makeZeroWidthPenalty(int penaltyValue) {
+    private KnuthPenalty makeZeroWidthPenalty(final int penaltyValue) {
         return new KnuthPenalty(
                 0,
                 penaltyValue,
                 false,
-                auxiliaryPosition,
+                this.auxiliaryPosition,
                 true);
     }
 
@@ -202,25 +200,25 @@
         return new KnuthInlineBox(
                 0,
                 null,
-                notifyPos(new LeafPosition(this, -1)),
+                this.notifyPos(new LeafPosition(this, -1)),
                 true);
     }
 
     /** {@inheritDoc} */
     public void initialize() {
-        
-        spaceFont = FontSelector.selectFontForCharacterInText(' ', foText, this);
+
+        this.spaceFont = FontSelector.selectFontForCharacterInText(' ', this.foText, this);
 
         // With CID fonts, space isn't neccesary currentFontState.width(32)
-        spaceCharIPD = spaceFont.getCharWidth(' ');
+        this.spaceCharIPD = this.spaceFont.getCharWidth(' ');
         // Use hyphenationChar property
-        
+
         // TODO: Use hyphen based on actual font used!
-        hyphIPD = foText.getCommonHyphenation().getHyphIPD(spaceFont);
+        this.hyphIPD = this.foText.getCommonHyphenation().getHyphIPD(this.spaceFont);
 
-        SpaceVal ls = SpaceVal.makeLetterSpacing(foText.getLetterSpacing());
+        final SpaceVal ls = SpaceVal.makeLetterSpacing(this.foText.getLetterSpacing());
 
-        ws = SpaceVal.makeWordSpacing(foText.getWordSpacing(), ls, spaceFont);
+        this.ws = SpaceVal.makeWordSpacing(this.foText.getWordSpacing(), ls, this.spaceFont);
 
         // letter space applies only to consecutive non-space characters,
         // while word space applies to space characters;
@@ -233,10 +231,11 @@
         // set letter space and word space dimension;
         // the default value "normal" was converted into a MinOptMax value
         // in the SpaceVal.makeWordSpacing() method
-        letterSpaceIPD = ls.getSpace();
-        wordSpaceIPD = MinOptMax.add(new MinOptMax(spaceCharIPD), ws.getSpace());
+        this.letterSpaceIPD = ls.getSpace();
+        this.wordSpaceIPD = MinOptMax.add(new MinOptMax(this.spaceCharIPD), this.ws.getSpace());
 
-        keepTogether = foText.getKeepTogether().getWithinLine().getEnum() == Constants.EN_ALWAYS;
+        this.keepTogether = this.foText.getKeepTogether().getWithinLine()
+                .getEnum() == Constants.EN_ALWAYS;
 
     }
 
@@ -250,10 +249,10 @@
      * by this LayoutManager.
      * @param context LayoutContext for adjustments
      */
-    public void addAreas(PositionIterator posIter, LayoutContext context) {
+    public void addAreas(final PositionIterator posIter, final LayoutContext context) {
 
         // Add word areas
-        AreaInfo ai; 
+        AreaInfo ai;
         int wordSpaceCount = 0;
         int letterSpaceCount = 0;
         int firstAreaInfoIndex = -1;
@@ -265,12 +264,12 @@
          */
         AreaInfo lastAi = null;
         while (posIter.hasNext()) {
-            LeafPosition tbpNext = (LeafPosition) posIter.next();
+            final LeafPosition tbpNext = (LeafPosition) posIter.next();
             if (tbpNext == null) {
                 continue; //Ignore elements without Positions
             }
             if (tbpNext.getLeafPos() != -1) {
-                ai = (AreaInfo) vecAreaInfo.get(tbpNext.getLeafPos());
+                ai = (AreaInfo) this.vecAreaInfo.get(tbpNext.getLeafPos());
                 if (lastAi == null || ai.font != lastAi.font) {
                     if (lastAi != null) {
                         this.addAreaInfoAreas(lastAi, wordSpaceCount,
@@ -280,8 +279,8 @@
                     firstAreaInfoIndex = tbpNext.getLeafPos();
                     wordSpaceCount = 0;
                     letterSpaceCount = 0;
-                    realWidth = new MinOptMax(0);                    
-                } 
+                    realWidth = new MinOptMax(0);
+                }
                 wordSpaceCount += ai.wordSpaceCount;
                 letterSpaceCount += ai.letterSpaceCount;
                 realWidth.add(ai.areaIPD);
@@ -294,26 +293,26 @@
                     firstAreaInfoIndex, lastAreaInfoIndex, realWidth, context);
         }
     }
-        
-    private void addAreaInfoAreas(AreaInfo ai, int wordSpaceCount,
-            int letterSpaceCount, int firstAreaInfoIndex,
-            int lastAreaInfoIndex, MinOptMax realWidth, LayoutContext context) {
-        
+
+    private void addAreaInfoAreas(final AreaInfo ai, final int wordSpaceCount,
+            int letterSpaceCount, final int firstAreaInfoIndex,
+            final int lastAreaInfoIndex, final MinOptMax realWidth, final LayoutContext context) {
+
         // TODO: These two statements (if, for) where like this before my recent
         // changes. However, it seems as if they should use the AreaInfo from
         // firstAreaInfoIndex.. lastAreaInfoIndex rather than just the last ai.
         // This needs to be checked.
-        int textLength = ai.breakIndex - ai.startIndex;
+        final int textLength = ai.breakIndex - ai.startIndex;
         if (ai.letterSpaceCount == textLength && !ai.isHyphenated
                    && context.isLastArea()) {
             // the line ends at a character like "/" or "-";
             // remove the letter space after the last character
-            realWidth.add(MinOptMax.multiply(letterSpaceIPD, -1));
+            realWidth.add(MinOptMax.multiply(this.letterSpaceIPD, -1));
             letterSpaceCount--;
         }
 
         for (int i = ai.startIndex; i < ai.breakIndex; i++) {
-            MinOptMax ladj = letterAdjustArray[i + 1];
+            final MinOptMax ladj = this.letterAdjustArray[i + 1];
             if (ladj != null && ladj.isElastic()) {
                 letterSpaceCount++;
             }
@@ -321,58 +320,56 @@
 
         // add hyphenation character if the last word is hyphenated
         if (context.isLastArea() && ai.isHyphenated) {
-            realWidth.add(new MinOptMax(hyphIPD));
+            realWidth.add(new MinOptMax(this.hyphIPD));
         }
 
         // Calculate adjustments
         int difference = 0;
         int totalAdjust = 0;
-        int wordSpaceDim = wordSpaceIPD.opt;
-        int letterSpaceDim = letterSpaceIPD.opt;
-        double ipdAdjust = context.getIPDAdjust();
-        double dSpaceAdjust = context.getSpaceAdjust(); // not used
+        int wordSpaceDim = this.wordSpaceIPD.opt;
+        int letterSpaceDim = this.letterSpaceIPD.opt;
+        final double ipdAdjust = context.getIPDAdjust();
 
         // calculate total difference between real and available width
         if (ipdAdjust > 0.0) {
-            difference = (int) ((double) (realWidth.max - realWidth.opt)
+            difference = (int) ((realWidth.max - realWidth.opt)
                                 * ipdAdjust);
         } else {
-            difference = (int) ((double) (realWidth.opt - realWidth.min)
+            difference = (int) ((realWidth.opt - realWidth.min)
                                 * ipdAdjust);
         }
 
         // set letter space adjustment
         if (ipdAdjust > 0.0) {
             letterSpaceDim
-                += (int) ((double) (letterSpaceIPD.max - letterSpaceIPD.opt)
+                += (int) ((this.letterSpaceIPD.max - this.letterSpaceIPD.opt)
                          * ipdAdjust);
         } else  {
             letterSpaceDim
-                += (int) ((double) (letterSpaceIPD.opt - letterSpaceIPD.min)
+                += (int) ((this.letterSpaceIPD.opt - this.letterSpaceIPD.min)
                          * ipdAdjust);
         }
-        totalAdjust += (letterSpaceDim - letterSpaceIPD.opt) * letterSpaceCount;
+        totalAdjust += (letterSpaceDim - this.letterSpaceIPD.opt) * letterSpaceCount;
 
         // set word space adjustment
         //
         if (wordSpaceCount > 0) {
             wordSpaceDim += (difference - totalAdjust) / wordSpaceCount;
-        } else {
-            // there are no word spaces in this area
         }
-        totalAdjust += (wordSpaceDim - wordSpaceIPD.opt) * wordSpaceCount;
+        totalAdjust += (wordSpaceDim - this.wordSpaceIPD.opt) * wordSpaceCount;
         if (totalAdjust != difference) {
             // the applied adjustment is greater or smaller than the needed one
-            log.trace("TextLM.addAreas: error in word / letter space adjustment = "
-                    + (totalAdjust - difference));
+            TextLayoutManager.LOG
+                    .trace("TextLM.addAreas: error in word / letter space adjustment = "
+                            + (totalAdjust - difference));
             // set totalAdjust = difference, so that the width of the TextArea
             // will counterbalance the error and the other inline areas will be
             // placed correctly
             totalAdjust = difference;
         }
 
-        TextArea t = createTextArea(realWidth, totalAdjust, context,
-                wordSpaceIPD.opt - spaceCharIPD, firstAreaInfoIndex,
+        final TextArea t = this.createTextArea(realWidth, totalAdjust, context,
+                this.wordSpaceIPD.opt - this.spaceCharIPD, firstAreaInfoIndex,
                 lastAreaInfoIndex, context.isLastArea(), ai.font);
 
         // wordSpaceDim is computed in relation to wordSpaceIPD.opt
@@ -388,14 +385,14 @@
         //       + (wordSpaceDim - spaceCharIPD -  2 * letterSpaceAdjust)
         //     = wordSpaceDim - letterSpaceAdjust
         t.setTextLetterSpaceAdjust(letterSpaceDim);
-        t.setTextWordSpaceAdjust(wordSpaceDim - spaceCharIPD
+        t.setTextWordSpaceAdjust(wordSpaceDim - this.spaceCharIPD
                                  - 2 * t.getTextLetterSpaceAdjust());
         if (context.getIPDAdjust() != 0) {
             // add information about space width
-            t.setSpaceDifference(wordSpaceIPD.opt - spaceCharIPD
+            t.setSpaceDifference(this.wordSpaceIPD.opt - this.spaceCharIPD
                                  - 2 * t.getTextLetterSpaceAdjust());
         }
-        parentLM.addChildArea(t);
+        this.parentLM.addChildArea(t);
     }
 
     /**
@@ -412,9 +409,9 @@
      * @param font Font to be used in this particular TextArea
      * @return the new text area
      */
-    protected TextArea createTextArea(MinOptMax width, int adjust,
-            LayoutContext context, int spaceDiff, int firstIndex,
-            int lastIndex, boolean isLastArea, Font font) {
+    protected TextArea createTextArea(final MinOptMax width, final int adjust,
+            final LayoutContext context, final int spaceDiff, final int firstIndex,
+            final int lastIndex, final boolean isLastArea, final Font font) {
         TextArea textArea;
         if (context.getIPDAdjust() == 0.0) {
             // create just a TextArea
@@ -428,12 +425,12 @@
         }
         textArea.setIPD(width.opt + adjust);
         textArea.setBPD(font.getAscender() - font.getDescender());
-        
+
         textArea.setBaselineOffset(font.getAscender());
-        if (textArea.getBPD() == alignmentContext.getHeight()) {
+        if (textArea.getBPD() == this.alignmentContext.getHeight()) {
             textArea.setOffset(0);
         } else {
-            textArea.setOffset(alignmentContext.getOffset());
+            textArea.setOffset(this.alignmentContext.getOffset());
         }
 
         // set the text of the TextArea, split into words and spaces
@@ -441,12 +438,12 @@
         AreaInfo areaInfo;
         int len = 0;
         for (int i = firstIndex; i <= lastIndex; i++) {
-            areaInfo = (AreaInfo) vecAreaInfo.get(i);
+            areaInfo = (AreaInfo) this.vecAreaInfo.get(i);
             if (areaInfo.isSpace) {
                 // areaInfo stores information about spaces
                 // add the spaces - except zero-width spaces - to the TextArea
                 for (int j = areaInfo.startIndex; j < areaInfo.breakIndex; j++) {
-                    char spaceChar = textArray[j];
+                    final char spaceChar = this.textArray[j];
                     if (!CharUtilities.isZeroWidthSpace(spaceChar)) {
                         textArea.addSpace(spaceChar, 0,
                                 CharUtilities.isAdjustableSpace(spaceChar));
@@ -460,7 +457,7 @@
                     len = 0;
                 }
                 len += areaInfo.breakIndex - areaInfo.startIndex;
-                if (i == lastIndex || ((AreaInfo) vecAreaInfo.get(i + 1)).isSpace) {
+                if (i == lastIndex || ((AreaInfo) this.vecAreaInfo.get(i + 1)).isSpace) {
                     // here ends a new word
                     // add a word to the TextArea
                     if (isLastArea
@@ -468,17 +465,19 @@
                         && areaInfo.isHyphenated) {
                         len++;
                     }
-                    StringBuffer wordChars = new StringBuffer(len);
-                    int[] letterAdjust = new int[len];
+                    final StringBuffer wordChars = new StringBuffer(len);
+                    final int[] letterAdjust = new int[len];
                     int letter = 0;
                     for (int j = wordStartIndex; j <= i; j++) {
-                        AreaInfo ai = (AreaInfo) vecAreaInfo.get(j);
+                        final AreaInfo ai = (AreaInfo) this.vecAreaInfo.get(j);
                         int lsCount = ai.letterSpaceCount;
-                        wordChars.append(textArray, ai.startIndex, ai.breakIndex - ai.startIndex);
+                        wordChars.append(this.textArray, ai.startIndex,
+                                ai.breakIndex - ai.startIndex);
                         for (int k = 0; k < ai.breakIndex - ai.startIndex; k++) {
-                            MinOptMax adj = letterAdjustArray[ai.startIndex + k];
+                            final MinOptMax adj = this.letterAdjustArray[ai.startIndex + k];
                             if (letter > 0) {
-                                letterAdjust[letter] = (adj != null ? adj.opt : 0);
+                                letterAdjust[letter] = adj == null ? 0
+                                        : adj.opt;
                             }
                             if (lsCount > 0) {
                                 letterAdjust[letter] += textArea.getTextLetterSpaceAdjust();
@@ -492,7 +491,7 @@
                         && i == lastIndex
                         && areaInfo.isHyphenated) {
                         // add the hyphenation character
-                        wordChars.append(foText.getCommonHyphenation().getHyphChar(font));
+                        wordChars.append(this.foText.getCommonHyphenation().getHyphChar(font));
                     }
                     textArea.addWord(wordChars.toString(), 0, letterAdjust);
                     wordStartIndex = -1;
@@ -500,18 +499,18 @@
             }
         }
         TraitSetter.addFontTraits(textArea, font);
-        textArea.addTrait(Trait.COLOR, foText.getColor());
+        textArea.addTrait(Trait.COLOR, this.foText.getColor());
 
-        TraitSetter.addTextDecoration(textArea, foText.getTextDecoration());
+        TraitSetter.addTextDecoration(textArea, this.foText.getTextDecoration());
 
         return textArea;
     }
 
-    private void addToLetterAdjust(int index, int width) {
-        if (letterAdjustArray[index] == null) {
-            letterAdjustArray[index] = new MinOptMax(width);
+    private void addToLetterAdjust(final int index, final int width) {
+        if (this.letterAdjustArray[index] == null) {
+            this.letterAdjustArray[index] = new MinOptMax(width);
         } else {
-            letterAdjustArray[index].add(width);
+            this.letterAdjustArray[index].add(width);
         }
     }
 
@@ -527,26 +526,27 @@
     }
 
     /** {@inheritDoc} */
-    public LinkedList getNextKnuthElements(LayoutContext context, int alignment) {
-        lineStartBAP = context.getLineStartBorderAndPaddingWidth();
-        lineEndBAP = context.getLineEndBorderAndPaddingWidth();
-        alignmentContext = context.getAlignmentContext();
+    public LinkedList getNextKnuthElements(final LayoutContext context, final int alignment) {
+        this.lineStartBAP = context.getLineStartBorderAndPaddingWidth();
+        this.lineEndBAP = context.getLineEndBorderAndPaddingWidth();
+        this.alignmentContext = context.getAlignmentContext();
 
-        LinkedList returnList = new LinkedList();
+        final LinkedList returnList = new LinkedList();
         KnuthSequence sequence = new InlineKnuthSequence();
         AreaInfo ai = null;
         AreaInfo prevAi = null;
         returnList.add(sequence);
 
-        LineBreakStatus lbs = new LineBreakStatus();
-        thisStart = nextStart;
+        final LineBreakStatus lbs = new LineBreakStatus();
+        this.thisStart = this.nextStart;
         boolean inWord = false;
         boolean inWhitespace = false;
         char ch = 0;
-        while (nextStart < textArray.length) {
-            ch = textArray[nextStart];
+        while (this.nextStart < this.textArray.length) {
+            ch = this.textArray[this.nextStart];
             boolean breakOpportunity = false;
-            byte breakAction = keepTogether ? LineBreakStatus.PROHIBITED_BREAK : lbs.nextChar(ch);
+            final byte breakAction = this.keepTogether ? LineBreakStatus.PROHIBITED_BREAK
+                    : lbs.nextChar(ch);
             switch (breakAction) {
                 case LineBreakStatus.COMBINING_PROHIBITED_BREAK:
                 case LineBreakStatus.PROHIBITED_BREAK:
@@ -559,106 +559,113 @@
                     breakOpportunity = true;
                     break;
                 default:
-                    log.error("Unexpected breakAction: " + breakAction);
+                    TextLayoutManager.LOG.error("Unexpected breakAction: " + breakAction);
             }
             if (inWord) {
-                if (breakOpportunity || isSpace(ch) || ch == NEWLINE) {
+                if (breakOpportunity || TextLayoutManager.isSpace(ch)
+                        || ch == TextLayoutManager.NEWLINE) {
                     //Word boundary found, process widths and kerning
-                    short lastIndex = nextStart;
-                    while (lastIndex > 0 && textArray[lastIndex - 1] == CharUtilities.SOFT_HYPHEN) {
+                    short lastIndex = this.nextStart;
+                    while (lastIndex > 0
+                            && this.textArray[lastIndex - 1] == CharUtilities.SOFT_HYPHEN) {
                         lastIndex--;
                     }
                     final Font font = FontSelector
-                            .selectFontForCharactersInText(textArray,
-                                    thisStart, lastIndex, foText, this);
-                    int wordLength = lastIndex - thisStart;
-                    boolean kerning = font.hasKerning();
-                    MinOptMax wordIPD = new MinOptMax(0);
-                    for (int i = thisStart; i < lastIndex; i++) {
-                        char c = textArray[i];
+                            .selectFontForCharactersInText(this.textArray,
+                                    this.thisStart, lastIndex, this.foText, this);
+                    final int wordLength = lastIndex - this.thisStart;
+                    final boolean kerning = font.hasKerning();
+                    final MinOptMax wordIPD = new MinOptMax(0);
+                    for (int i = this.thisStart; i < lastIndex; i++) {
+                        final char c = this.textArray[i];
 
                         //character width
-                        int charWidth = font.getCharWidth(c);
+                        final int charWidth = font.getCharWidth(c);
                         wordIPD.add(charWidth);
 
                         //kerning
                         if (kerning) {
                             int kern = 0;
-                            if (i > thisStart) {
-                                char previous = textArray[i - 1];
+                            if (i > this.thisStart) {
+                                final char previous = this.textArray[i - 1];
                                 kern = font.getKernValue(previous, c) * font.getFontSize() / 1000;
                             } else if (prevAi != null && !prevAi.isSpace && prevAi.breakIndex > 0) {
-                                char previous = textArray[prevAi.breakIndex - 1];
+                                final char previous = this.textArray[prevAi.breakIndex - 1];
                                 kern = font.getKernValue(previous, c) * font.getFontSize() / 1000;
                             }
                             if (kern != 0) {
-                                //log.info("Kerning between " + previous + " and " + c + ": " + kern);
-                                addToLetterAdjust(i, kern);
+                                this.addToLetterAdjust(i, kern);
                                 wordIPD.add(kern);
                             }
                         }
                     }
-                    if (kerning && breakOpportunity && !isSpace(ch) && lastIndex > 0 && textArray[lastIndex] == CharUtilities.SOFT_HYPHEN) {
-                        int kern = font.getKernValue(textArray[lastIndex - 1], ch) * font.getFontSize() / 1000;
+                    if (kerning
+                            && breakOpportunity
+                            && !TextLayoutManager.isSpace(ch)
+                            && lastIndex > 0
+                            && this.textArray[lastIndex] == CharUtilities.SOFT_HYPHEN) {
+                        final int kern = font.getKernValue(
+                                this.textArray[lastIndex - 1], ch)
+                                * font.getFontSize() / 1000;
                         if (kern != 0) {
-                            addToLetterAdjust(lastIndex, kern);
+                            this.addToLetterAdjust(lastIndex, kern);
                         }
                     }
                     int iLetterSpaces = wordLength - 1;
                     // if there is a break opportunity and the next one
                     // is not a space, it could be used as a line end;
                     // add one more letter space, in case other text follows
-                    if (breakOpportunity && !isSpace(ch)) {
+                    if (breakOpportunity && !TextLayoutManager.isSpace(ch)) {
                         iLetterSpaces++;
                     }
-                    wordIPD.add(MinOptMax.multiply(letterSpaceIPD, iLetterSpaces));
+                    wordIPD.add(MinOptMax.multiply(this.letterSpaceIPD, iLetterSpaces));
 
                     // create the AreaInfo object
-                    ai = new AreaInfo(thisStart, lastIndex, (short) 0,
+                    ai = new AreaInfo(this.thisStart, lastIndex, (short) 0,
                             (short) iLetterSpaces, wordIPD,
-                            textArray[lastIndex] == CharUtilities.SOFT_HYPHEN,
+                            this.textArray[lastIndex] == CharUtilities.SOFT_HYPHEN,
                             false, breakOpportunity, font);
                     prevAi = ai;
-                    vecAreaInfo.add(ai);
-                    tempStart = nextStart;
+                    this.vecAreaInfo.add(ai);
+                    this.tempStart = this.nextStart;
 
                     //add the elements
-                    addElementsForAWordFragment(sequence, alignment, ai,
-                            vecAreaInfo.size() - 1, letterSpaceIPD);
+                    this.addElementsForAWordFragment(sequence, alignment, ai,
+                            this.vecAreaInfo.size() - 1, this.letterSpaceIPD);
                     ai = null;
-                    thisStart = nextStart;
+                    this.thisStart = this.nextStart;
                 }
             } else if (inWhitespace) {
                 if (ch != CharUtilities.SPACE || breakOpportunity) {
                     // End of whitespace
                     // create the AreaInfo object
-                    ai = new AreaInfo(thisStart, nextStart,
-                            (short) (nextStart - thisStart), (short) 0,
-                            MinOptMax.multiply(wordSpaceIPD, nextStart
-                                    - thisStart), false, true,
-                            breakOpportunity, spaceFont);
-                    vecAreaInfo.add(ai);
+                    ai = new AreaInfo(this.thisStart, this.nextStart,
+                            (short) (this.nextStart - this.thisStart), (short) 0,
+                            MinOptMax.multiply(this.wordSpaceIPD, this.nextStart
+                                    - this.thisStart), false, true,
+                            breakOpportunity, this.spaceFont);
+                    this.vecAreaInfo.add(ai);
                     prevAi = ai;
 
                     // create the elements
-                    addElementsForASpace(sequence, alignment, ai, vecAreaInfo.size() - 1);
+                    this.addElementsForASpace(sequence, alignment, ai, this.vecAreaInfo.size() - 1);
                     ai = null;
 
-                    thisStart = nextStart;
+                    this.thisStart = this.nextStart;
                 }
             } else {
                 if (ai != null) {
-                    vecAreaInfo.add(ai);
+                    this.vecAreaInfo.add(ai);
                     prevAi = ai;
-                    ai.breakOppAfter = (ch == CharUtilities.SPACE) || breakOpportunity;
-                    addElementsForASpace(sequence, alignment, ai, vecAreaInfo.size() - 1);
+                    ai.breakOppAfter = ch == CharUtilities.SPACE || breakOpportunity;
+                    this.addElementsForASpace(sequence, alignment, ai, this.vecAreaInfo.size() - 1);
                     ai = null;
                 }
                 if (breakAction == LineBreakStatus.EXPLICIT_BREAK) {
-                    if (lineEndBAP != 0) {
+                    if (this.lineEndBAP != 0) {
                         sequence.add(
-                                new KnuthGlue(lineEndBAP, 0, 0,
-                                              auxiliaryPosition, true));
+                                new KnuthGlue(this.lineEndBAP, 0, 0,
+                                              this.auxiliaryPosition, true));
                     }
                     sequence.endSequence();
                     sequence = new InlineKnuthSequence();
@@ -666,101 +673,102 @@
                 }
             }
 
-            if ((ch == CharUtilities.SPACE
-                    && foText.getWhitespaceTreatment() == Constants.EN_PRESERVE)
+            if (ch == CharUtilities.SPACE
+                    && this.foText.getWhitespaceTreatment() == Constants.EN_PRESERVE
                     || ch == CharUtilities.NBSPACE) {
                 // preserved space or non-breaking space:
                 // create the AreaInfo object
-                ai = new AreaInfo(nextStart, (short) (nextStart + 1),
-                        (short) 1, (short) 0, wordSpaceIPD, false, true,
-                        breakOpportunity, spaceFont);
-                thisStart = (short) (nextStart + 1);
+                ai = new AreaInfo(this.nextStart, (short) (this.nextStart + 1),
+                        (short) 1, (short) 0, this.wordSpaceIPD, false, true,
+                        breakOpportunity, this.spaceFont);
+                this.thisStart = (short) (this.nextStart + 1);
             } else if (CharUtilities.isFixedWidthSpace(ch) || CharUtilities.isZeroWidthSpace(ch)) {
                 // create the AreaInfo object
                 final Font font = FontSelector.selectFontForCharacterInText(ch,
-                        foText, this);
-                MinOptMax ipd = new MinOptMax(font.getCharWidth(ch));
-                ai = new AreaInfo(nextStart, (short) (nextStart + 1),
+                        this.foText, this);
+                final MinOptMax ipd = new MinOptMax(font.getCharWidth(ch));
+                ai = new AreaInfo(this.nextStart, (short) (this.nextStart + 1),
                         (short) 0, (short) 0, ipd, false, true,
                         breakOpportunity, font);
-                thisStart = (short) (nextStart + 1);
-            } else if (ch == NEWLINE) {
+                this.thisStart = (short) (this.nextStart + 1);
+            } else if (ch == TextLayoutManager.NEWLINE) {
                 // linefeed; this can happen when linefeed-treatment="preserve"
-                thisStart = (short) (nextStart + 1);
+                this.thisStart = (short) (this.nextStart + 1);
             }
-            inWord = !isSpace(ch) && ch != NEWLINE;
-            inWhitespace = ch == CharUtilities.SPACE && foText.getWhitespaceTreatment() != Constants.EN_PRESERVE;
-            nextStart++;
+            inWord = !TextLayoutManager.isSpace(ch)
+                    && ch != TextLayoutManager.NEWLINE;
+            inWhitespace = ch == CharUtilities.SPACE
+                    && this.foText.getWhitespaceTreatment() != Constants.EN_PRESERVE;
+            this.nextStart++;
         } // end of while
 
         // Process any last elements
         if (inWord) {
-            int lastIndex = nextStart;
-            if (textArray[nextStart - 1] == CharUtilities.SOFT_HYPHEN) {
+            int lastIndex = this.nextStart;
+            if (this.textArray[this.nextStart - 1] == CharUtilities.SOFT_HYPHEN) {
                 lastIndex--;
             }
-            int wordLength = lastIndex - thisStart;
+            final int wordLength = lastIndex - this.thisStart;
             final Font font = FontSelector.selectFontForCharactersInText(
-                    textArray, thisStart, lastIndex, foText, this);
-            boolean kerning = font.hasKerning();
-            MinOptMax wordIPD = new MinOptMax(0);
-            for (int i = thisStart; i < lastIndex; i++) {
-                char c = textArray[i];
+                    this.textArray, this.thisStart, lastIndex, this.foText, this);
+            final boolean kerning = font.hasKerning();
+            final MinOptMax wordIPD = new MinOptMax(0);
+            for (int i = this.thisStart; i < lastIndex; i++) {
+                final char c = this.textArray[i];
 
                 //character width
-                int charWidth = font.getCharWidth(c);
+                final int charWidth = font.getCharWidth(c);
                 wordIPD.add(charWidth);
 
                 //kerning
                 if (kerning) {
                     int kern = 0;
-                    if (i > thisStart) {
-                        char previous = textArray[i - 1];
+                    if (i > this.thisStart) {
+                        final char previous = this.textArray[i - 1];
                         kern = font.getKernValue(previous, c) * font.getFontSize() / 1000;
                     } else if (prevAi != null && !prevAi.isSpace) {
-                        char previous = textArray[prevAi.breakIndex - 1];
+                        final char previous = this.textArray[prevAi.breakIndex - 1];
                         kern = font.getKernValue(previous, c) * font.getFontSize() / 1000;
                     }
                     if (kern != 0) {
-                        //log.info("Kerning between " + previous + " and " + c + ": " + kern);
-                        addToLetterAdjust(i, kern);
+                        this.addToLetterAdjust(i, kern);
                         wordIPD.add(kern);
                     }
                 }
             }
-            int iLetterSpaces = wordLength - 1;
-            wordIPD.add(MinOptMax.multiply(letterSpaceIPD, iLetterSpaces));
+            final int iLetterSpaces = wordLength - 1;
+            wordIPD.add(MinOptMax.multiply(this.letterSpaceIPD, iLetterSpaces));
 
             // create the AreaInfo object
-            ai = new AreaInfo(thisStart, (short) lastIndex, (short) 0,
+            ai = new AreaInfo(this.thisStart, (short) lastIndex, (short) 0,
                     (short) iLetterSpaces, wordIPD, false, false, false, font);
-            vecAreaInfo.add(ai);
-            tempStart = nextStart;
+            this.vecAreaInfo.add(ai);
+            this.tempStart = this.nextStart;
 
             // create the elements
-            addElementsForAWordFragment(sequence, alignment, ai,
-                    vecAreaInfo.size() - 1, letterSpaceIPD);
+            this.addElementsForAWordFragment(sequence, alignment, ai,
+                    this.vecAreaInfo.size() - 1, this.letterSpaceIPD);
             ai = null;
         } else if (inWhitespace) {
-            ai = new AreaInfo(thisStart, (short) (nextStart),
-                    (short) (nextStart - thisStart), (short) 0, MinOptMax
-                            .multiply(wordSpaceIPD, nextStart - thisStart),
-                    false, true, true, spaceFont);
-            vecAreaInfo.add(ai);
+            ai = new AreaInfo(this.thisStart, this.nextStart,
+                    (short) (this.nextStart - this.thisStart), (short) 0, MinOptMax
+                            .multiply(this.wordSpaceIPD, this.nextStart - this.thisStart),
+                    false, true, true, this.spaceFont);
+            this.vecAreaInfo.add(ai);
 
             // create the elements
-            addElementsForASpace(sequence, alignment, ai, vecAreaInfo.size() - 1);
+            this.addElementsForASpace(sequence, alignment, ai, this.vecAreaInfo.size() - 1);
             ai = null;
         } else if (ai != null) {
-            vecAreaInfo.add(ai);
+            this.vecAreaInfo.add(ai);
             ai.breakOppAfter = ch == CharUtilities.ZERO_WIDTH_SPACE;
-            addElementsForASpace(sequence, alignment, ai, vecAreaInfo.size() - 1);
+            this.addElementsForASpace(sequence, alignment, ai, this.vecAreaInfo.size() - 1);
             ai = null;
-        } else if (ch == NEWLINE) {
-            if (lineEndBAP != 0) {
+        } else if (ch == TextLayoutManager.NEWLINE) {
+            if (this.lineEndBAP != 0) {
                 sequence.add
-                    (new KnuthGlue(lineEndBAP, 0, 0,
-                                   auxiliaryPosition, true));
+                    (new KnuthGlue(this.lineEndBAP, 0, 0,
+                                   this.auxiliaryPosition, true));
             }
             sequence.endSequence();
             sequence = new InlineKnuthSequence();
@@ -771,49 +779,54 @@
             //Remove an empty sequence because of a trailing newline
             returnList.removeLast();
         }
-        setFinished(true);
-        if (returnList.size() > 0) {
-            return returnList;
-        } else {
+        this.setFinished(true);
+        if (returnList.isEmpty()) {
             return null;
+        } else {
+            return returnList;
         }
     }
 
     /** {@inheritDoc} */
-    public List addALetterSpaceTo(List oldList) {
+    public List addALetterSpaceTo(final List oldList) {
         // old list contains only a box, or the sequence: box penalty glue box;
         // look at the Position stored in the first element in oldList
         // which is always a box
         ListIterator oldListIterator = oldList.listIterator();
-        KnuthElement el = (KnuthElement)oldListIterator.next();
-        LeafPosition pos = (LeafPosition) ((KnuthBox) el).getPosition();
-        int idx = pos.getLeafPos();
+        final KnuthElement el = (KnuthElement)oldListIterator.next();
+        final LeafPosition pos = (LeafPosition) ((KnuthBox) el).getPosition();
+        final int idx = pos.getLeafPos();
         //element could refer to '-1' position, for non-collapsed spaces (?)
         if (idx > -1) {
-            AreaInfo ai = (AreaInfo) vecAreaInfo.get(idx);
+            final AreaInfo ai = (AreaInfo) this.vecAreaInfo.get(idx);
             ai.letterSpaceCount++;
-            ai.areaIPD.add(letterSpaceIPD);
-            if (BREAK_CHARS.indexOf(textArray[tempStart - 1]) >= 0) {
+            ai.areaIPD.add(this.letterSpaceIPD);
+            if (TextLayoutManager.BREAK_CHARS.indexOf(this.textArray[this.tempStart - 1]) >= 0) {
                 // the last character could be used as a line break
                 // append new elements to oldList
                 oldListIterator = oldList.listIterator(oldList.size());
                 oldListIterator.add(new KnuthPenalty(0, KnuthPenalty.FLAGGED_PENALTY, true,
-                                                     auxiliaryPosition, false));
-                oldListIterator.add(new KnuthGlue(letterSpaceIPD.opt,
-                                           letterSpaceIPD.max - letterSpaceIPD.opt,
-                                           letterSpaceIPD.opt - letterSpaceIPD.min,
-                                           auxiliaryPosition, false));
-            } else if (letterSpaceIPD.min == letterSpaceIPD.max) {
+                                                     this.auxiliaryPosition, false));
+                oldListIterator.add(new KnuthGlue(this.letterSpaceIPD.opt,
+                                           this.letterSpaceIPD.max - this.letterSpaceIPD.opt,
+                                           this.letterSpaceIPD.opt - this.letterSpaceIPD.min,
+                                           this.auxiliaryPosition, false));
+            } else if (this.letterSpaceIPD.min == this.letterSpaceIPD.max) {
                 // constant letter space: replace the box
-                oldListIterator.set(new KnuthInlineBox(ai.areaIPD.opt, alignmentContext, pos, false));
+                oldListIterator.set(new KnuthInlineBox(ai.areaIPD.opt,
+                        this.alignmentContext, pos, false));
             } else {
                 // adjustable letter space: replace the glue
                 oldListIterator.next(); // this would return the penalty element
                 oldListIterator.next(); // this would return the glue element
-                oldListIterator.set(new KnuthGlue(ai.letterSpaceCount * letterSpaceIPD.opt,
-                                                  ai.letterSpaceCount * (letterSpaceIPD.max - letterSpaceIPD.opt),
-                                                  ai.letterSpaceCount * (letterSpaceIPD.opt - letterSpaceIPD.min),
-                                                  auxiliaryPosition, true));
+                oldListIterator
+                        .set(new KnuthGlue(
+                                ai.letterSpaceCount * this.letterSpaceIPD.opt,
+                                ai.letterSpaceCount
+                                        * (this.letterSpaceIPD.max - this.letterSpaceIPD.opt),
+                                ai.letterSpaceCount
+                                        * (this.letterSpaceIPD.opt - this.letterSpaceIPD.min),
+                                this.auxiliaryPosition, true));
             }
         }
         return oldList;
@@ -826,10 +839,10 @@
      *
      * @param oldList the elements representing the word space
      */
-    public void removeWordSpace(List oldList) {
+    public void removeWordSpace(final List oldList) {
         // find the element storing the Position whose value
         // points to the AreaInfo object
-        ListIterator oldListIterator = oldList.listIterator();
+        final ListIterator oldListIterator = oldList.listIterator();
         if (((KnuthElement) ((LinkedList) oldList).getFirst()).isPenalty()) {
             // non breaking space: oldList starts with a penalty
             oldListIterator.next();
@@ -840,31 +853,31 @@
             oldListIterator.next();
             oldListIterator.next();
         }
-        int leafValue = ((LeafPosition) ((KnuthElement) oldListIterator.next()).getPosition()).getLeafPos();
+        final int leafValue = ((LeafPosition) ((KnuthElement) oldListIterator
+                .next()).getPosition()).getLeafPos();
         // only the last word space can be a trailing space!
-        if (leafValue == vecAreaInfo.size() - 1) {
-            vecAreaInfo.remove(leafValue);
+        if (leafValue == this.vecAreaInfo.size() - 1) {
+            this.vecAreaInfo.remove(leafValue);
         } else {
-            log.error("trying to remove a non-trailing word space");
+            TextLayoutManager.LOG.error("trying to remove a non-trailing word space");
         }
     }
 
     /** {@inheritDoc} */
-    public void hyphenate(Position pos, HyphContext hc) {
-        AreaInfo ai
-            = (AreaInfo) vecAreaInfo.get(((LeafPosition) pos).getLeafPos());
+    public void hyphenate(final Position pos, final HyphContext hc) {
+        final AreaInfo ai
+            = (AreaInfo) this.vecAreaInfo.get(((LeafPosition) pos).getLeafPos());
         int startIndex = ai.startIndex;
         int stopIndex;
         boolean nothingChanged = true;
         final Font font = ai.font;
 
         while (startIndex < ai.breakIndex) {
-            MinOptMax newIPD = new MinOptMax(0);
+            final MinOptMax newIPD = new MinOptMax(0);
             boolean hyphenFollows;
 
-            if (hc.hasMoreHyphPoints()
-                && (stopIndex = startIndex + hc.getNextHyphPoint())
-                <= ai.breakIndex) {
+            stopIndex = startIndex + hc.getNextHyphPoint();
+            if (hc.hasMoreHyphPoints() && stopIndex <= ai.breakIndex) {
                 // stopIndex is the index of the first character
                 // after a hyphenation point
                 hyphenFollows = true;
@@ -879,12 +892,12 @@
 
             //log.info("Word: " + new String(textArray, startIndex, stopIndex - startIndex));
             for (int i = startIndex; i < stopIndex; i++) {
-                char c = textArray[i];
+                final char c = this.textArray[i];
                 newIPD.add(new MinOptMax(font.getCharWidth(c)));
                 //if (i > startIndex) {
                 if (i < stopIndex) {
                     MinOptMax la = this.letterAdjustArray[i + 1];
-                    if ((i == stopIndex - 1) && hyphenFollows) {
+                    if (i == stopIndex - 1 && hyphenFollows) {
                         //the letter adjust here needs to be handled further down during
                         //element generation because it depends on hyph/no-hyph condition
                         la = null;
@@ -895,112 +908,113 @@
                 }
             }
             // add letter spaces
-            boolean isWordEnd
+            final boolean isWordEnd
                 = stopIndex == ai.breakIndex
-                && ai.letterSpaceCount < (ai.breakIndex - ai.startIndex);
-            newIPD.add(MinOptMax.multiply(letterSpaceIPD,
+                && ai.letterSpaceCount < ai.breakIndex - ai.startIndex;
+            newIPD.add(MinOptMax.multiply(this.letterSpaceIPD,
                                           (isWordEnd
-                                           ? (stopIndex - startIndex - 1)
-                                           : (stopIndex - startIndex))));
+                                           ? stopIndex - startIndex - 1
+                                           : stopIndex - startIndex)));
 
             if (!(nothingChanged
                   && stopIndex == ai.breakIndex
                   && !hyphenFollows)) {
                 // the new AreaInfo object is not equal to the old one
-                if (changeList == null) {
-                    changeList = new LinkedList();
+                if (this.changeList == null) {
+                    this.changeList = new LinkedList();
                 }
-                changeList.add(new PendingChange(new AreaInfo(
+                this.changeList.add(new PendingChange(new AreaInfo(
                         (short) startIndex, (short) stopIndex, (short) 0,
-                        (short) (isWordEnd ? (stopIndex - startIndex - 1)
-                                : (stopIndex - startIndex)), newIPD,
+                        (short) (isWordEnd ? stopIndex - startIndex - 1
+                                : stopIndex - startIndex), newIPD,
                         hyphenFollows, false, false, font),
                         ((LeafPosition) pos).getLeafPos()));
                 nothingChanged = false;
             }
             startIndex = stopIndex;
         }
-        hasChanged = !nothingChanged;
+        this.hasChanged = !nothingChanged;
     }
 
     /** {@inheritDoc} */
-    public boolean applyChanges(List oldList) {
-        setFinished(false);
+    public boolean applyChanges(final List oldList) {
+        this.setFinished(false);
 
-        if (changeList != null && !changeList.isEmpty()) {
+        if (this.changeList != null && !this.changeList.isEmpty()) {
             int areaInfosAdded = 0;
             int areaInfosRemoved = 0;
             int oldIndex = -1, changeIndex;
             PendingChange currChange;
-            ListIterator changeListIterator = changeList.listIterator();
+            final ListIterator changeListIterator = this.changeList.listIterator();
             while (changeListIterator.hasNext()) {
                 currChange = (PendingChange) changeListIterator.next();
-                if (currChange.index != oldIndex) {
-                    areaInfosRemoved++;
+                if (currChange.index == oldIndex) {
                     areaInfosAdded++;
-                    oldIndex = currChange.index;
                     changeIndex = currChange.index + areaInfosAdded - areaInfosRemoved;
-                    vecAreaInfo.remove(changeIndex);
                 } else {
+                    areaInfosRemoved++;
                     areaInfosAdded++;
+                    oldIndex = currChange.index;
                     changeIndex = currChange.index + areaInfosAdded - areaInfosRemoved;
+                    this.vecAreaInfo.remove(changeIndex);
                 }
-                vecAreaInfo.add(changeIndex, currChange.ai);
+                this.vecAreaInfo.add(changeIndex, currChange.ai);
             }
-            changeList.clear();
+            this.changeList.clear();
         }
 
-        returnedIndex = 0;
-        return hasChanged;
+        this.returnedIndex = 0;
+        return this.hasChanged;
     }
 
     /** {@inheritDoc} */
-    public LinkedList getChangedKnuthElements(List oldList,
-                                              int alignment) {
-        if (isFinished()) {
+    public LinkedList getChangedKnuthElements(final List oldList,
+                                              final int alignment) {
+        if (this.isFinished()) {
             return null;
         }
 
-        LinkedList returnList = new LinkedList();
+        final LinkedList returnList = new LinkedList();
 
-        while (returnedIndex < vecAreaInfo.size()) {
-            AreaInfo ai = (AreaInfo) vecAreaInfo.get(returnedIndex);
+        while (this.returnedIndex < this.vecAreaInfo.size()) {
+            final AreaInfo ai = (AreaInfo) this.vecAreaInfo.get(this.returnedIndex);
             if (ai.wordSpaceCount == 0) {
                 // ai refers either to a word or a word fragment
-                addElementsForAWordFragment(returnList, alignment, ai, returnedIndex, letterSpaceIPD);
+                this.addElementsForAWordFragment(returnList, alignment, ai,
+                        this.returnedIndex, this.letterSpaceIPD);
             } else {
                 // ai refers to a space
-                addElementsForASpace(returnList, alignment, ai, returnedIndex);
+                this.addElementsForASpace(returnList, alignment, ai, this.returnedIndex);
             }
-            returnedIndex++;
+            this.returnedIndex++;
         } // end of while
-        setFinished(true);
+        this.setFinished(true);
         //ElementListObserver.observe(returnList, "text-changed", null);
         return returnList;
     }
 
     /** {@inheritDoc} */
-    public void getWordChars(StringBuffer sbChars, Position pos) {
-        int leafValue = ((LeafPosition) pos).getLeafPos();
+    public void getWordChars(final StringBuffer sbChars, final Position pos) {
+        final int leafValue = ((LeafPosition) pos).getLeafPos();
         if (leafValue != -1) {
-            AreaInfo ai = (AreaInfo) vecAreaInfo.get(leafValue);
-            sbChars.append(textArray, ai.startIndex, ai.breakIndex - ai.startIndex);
+            final AreaInfo ai = (AreaInfo) this.vecAreaInfo.get(leafValue);
+            sbChars.append(this.textArray, ai.startIndex, ai.breakIndex - ai.startIndex);
         }
     }
 
-    private void addElementsForASpace(List baseList,
-                                      int alignment,
-                                      AreaInfo ai,
-                                      int leafValue) {
-        LeafPosition mainPosition = new LeafPosition(this, leafValue);
+    private void addElementsForASpace(final List baseList,
+                                      final int alignment,
+                                      final AreaInfo ai,
+                                      final int leafValue) {
+        final LeafPosition mainPosition = new LeafPosition(this, leafValue);
 
         if (!ai.breakOppAfter) {
             // a non-breaking space
-            if (alignment == EN_JUSTIFY) {
+            if (alignment == Constants.EN_JUSTIFY) {
                 // the space can stretch and shrink, and must be preserved
                 // when starting a line
-                baseList.add(makeAuxiliaryZeroWidthBox());
-                baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
+                baseList.add(this.makeAuxiliaryZeroWidthBox());
+                baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
                 baseList.add(new KnuthGlue(ai.areaIPD.opt, ai.areaIPD.max - ai.areaIPD.opt,
                         ai.areaIPD.opt - ai.areaIPD.min, mainPosition, false));
             } else {
@@ -1010,8 +1024,8 @@
                         mainPosition, true));
             }
         } else {
-            if (textArray[ai.startIndex] != CharUtilities.SPACE
-                    || foText.getWhitespaceTreatment() == Constants.EN_PRESERVE) {
+            if (this.textArray[ai.startIndex] != CharUtilities.SPACE
+                    || this.foText.getWhitespaceTreatment() == Constants.EN_PRESERVE) {
                 // a breaking space that needs to be preserved
                 switch (alignment) {
                 case EN_CENTER:
@@ -1019,17 +1033,17 @@
                     // if the second element is chosen as a line break these elements
                     // add a constant amount of stretch at the end of a line and at the
                     // beginning of the next one, otherwise they don't add any stretch
-                    baseList.add(new KnuthGlue(lineEndBAP,
+                    baseList.add(new KnuthGlue(this.lineEndBAP,
                             3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeZeroWidthPenalty(0));
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeZeroWidthPenalty(0));
                     baseList.add(new KnuthGlue(
-                            - (lineStartBAP + lineEndBAP), -6
+                            -(this.lineStartBAP + this.lineEndBAP), -6
                             * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeAuxiliaryZeroWidthBox());
-                    baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                    baseList.add(new KnuthGlue(ai.areaIPD.opt + lineStartBAP,
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeAuxiliaryZeroWidthBox());
+                    baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                    baseList.add(new KnuthGlue(ai.areaIPD.opt + this.lineStartBAP,
                             3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
                             mainPosition, false));
                     break;
@@ -1040,49 +1054,49 @@
                     // if the second element is chosen as a line break these elements
                     // add a constant amount of stretch at the end of a line, otherwise
                     // they don't add any stretch
-                    baseList.add(new KnuthGlue(lineEndBAP,
+                    baseList.add(new KnuthGlue(this.lineEndBAP,
                             3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeZeroWidthPenalty(0));
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeZeroWidthPenalty(0));
                     baseList.add(new KnuthGlue(
-                            - (lineStartBAP + lineEndBAP), -3
+                            -(this.lineStartBAP + this.lineEndBAP), -3
                             * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeAuxiliaryZeroWidthBox());
-                    baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                    baseList.add(new KnuthGlue(ai.areaIPD.opt + lineStartBAP, 0, 0,
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeAuxiliaryZeroWidthBox());
+                    baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                    baseList.add(new KnuthGlue(ai.areaIPD.opt + this.lineStartBAP, 0, 0,
                             mainPosition, false));
                     break;
 
                 case EN_JUSTIFY:
                     // justified text:
                     // the stretch and shrink depends on the space width
-                    baseList.add(new KnuthGlue(lineEndBAP, 0, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeZeroWidthPenalty(0));
+                    baseList.add(new KnuthGlue(this.lineEndBAP, 0, 0,
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeZeroWidthPenalty(0));
                     baseList.add(new KnuthGlue(
-                            - (lineStartBAP + lineEndBAP), ai.areaIPD.max
+                            -(this.lineStartBAP + this.lineEndBAP), ai.areaIPD.max
                             - ai.areaIPD.opt, ai.areaIPD.opt - ai.areaIPD.min,
-                            auxiliaryPosition, false));
-                    baseList.add(makeAuxiliaryZeroWidthBox());
-                    baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                    baseList.add(new KnuthGlue(lineStartBAP + ai.areaIPD.opt, 0, 0,
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeAuxiliaryZeroWidthBox());
+                    baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                    baseList.add(new KnuthGlue(this.lineStartBAP + ai.areaIPD.opt, 0, 0,
                             mainPosition, false));
                     break;
 
                 default:
                     // last line justified, the other lines unjustified:
                     // use only the space stretch
-                    baseList.add(new KnuthGlue(lineEndBAP, 0, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeZeroWidthPenalty(0));
+                    baseList.add(new KnuthGlue(this.lineEndBAP, 0, 0,
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeZeroWidthPenalty(0));
                     baseList.add(new KnuthGlue(
-                            - (lineStartBAP + lineEndBAP), ai.areaIPD.max
+                            -(this.lineStartBAP + this.lineEndBAP), ai.areaIPD.max
                             - ai.areaIPD.opt, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeAuxiliaryZeroWidthBox());
-                    baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                    baseList.add(new KnuthGlue(lineStartBAP + ai.areaIPD.opt, 0, 0,
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeAuxiliaryZeroWidthBox());
+                    baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                    baseList.add(new KnuthGlue(this.lineStartBAP + ai.areaIPD.opt, 0, 0,
                             mainPosition, false));
                 }
             } else {
@@ -1093,19 +1107,19 @@
                     // if the second element is chosen as a line break these elements
                     // add a constant amount of stretch at the end of a line and at the
                     // beginning of the next one, otherwise they don't add any stretch
-                    baseList.add(new KnuthGlue(lineEndBAP,
+                    baseList.add(new KnuthGlue(this.lineEndBAP,
                             3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
-                    baseList.add(makeZeroWidthPenalty(0));
+                            this.auxiliaryPosition, false));
+                    baseList.add(this.makeZeroWidthPenalty(0));
                     baseList.add(new KnuthGlue(ai.areaIPD.opt
-                            - (lineStartBAP + lineEndBAP), -6
+                            - (this.lineStartBAP + this.lineEndBAP), -6
                             * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
                             mainPosition, false));
-                    baseList.add(makeAuxiliaryZeroWidthBox());
-                    baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                    baseList.add(new KnuthGlue(lineStartBAP,
+                    baseList.add(this.makeAuxiliaryZeroWidthBox());
+                    baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                    baseList.add(new KnuthGlue(this.lineStartBAP,
                             3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
+                            this.auxiliaryPosition, false));
                     break;
 
                 case EN_START: // fall through
@@ -1114,24 +1128,24 @@
                     // if the second element is chosen as a line break these elements
                     // add a constant amount of stretch at the end of a line, otherwise
                     // they don't add any stretch
-                    if (lineStartBAP != 0 || lineEndBAP != 0) {
-                        baseList.add(new KnuthGlue(lineEndBAP,
+                    if (this.lineStartBAP != 0 || this.lineEndBAP != 0) {
+                        baseList.add(new KnuthGlue(this.lineEndBAP,
                                 3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                                auxiliaryPosition, false));
-                        baseList.add(makeZeroWidthPenalty(0));
+                                this.auxiliaryPosition, false));
+                        baseList.add(this.makeZeroWidthPenalty(0));
                         baseList.add(new KnuthGlue(ai.areaIPD.opt
-                                - (lineStartBAP + lineEndBAP), -3
+                                - (this.lineStartBAP + this.lineEndBAP), -3
                                 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
                                 mainPosition, false));
-                        baseList.add(makeAuxiliaryZeroWidthBox());
-                        baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                        baseList.add(new KnuthGlue(lineStartBAP, 0, 0,
-                                auxiliaryPosition, false));
+                        baseList.add(this.makeAuxiliaryZeroWidthBox());
+                        baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                        baseList.add(new KnuthGlue(this.lineStartBAP, 0, 0,
+                                this.auxiliaryPosition, false));
                     } else {
                         baseList.add(new KnuthGlue(0,
                                 3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                                auxiliaryPosition, false));
-                        baseList.add(makeZeroWidthPenalty(0));
+                                this.auxiliaryPosition, false));
+                        baseList.add(this.makeZeroWidthPenalty(0));
                         baseList.add(new KnuthGlue(ai.areaIPD.opt, -3
                                 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
                                 mainPosition, false));
@@ -1141,19 +1155,19 @@
                 case EN_JUSTIFY:
                     // justified text:
                     // the stretch and shrink depends on the space width
-                    if (lineStartBAP != 0 || lineEndBAP != 0) {
-                        baseList.add(new KnuthGlue(lineEndBAP, 0, 0,
-                                auxiliaryPosition, false));
-                        baseList.add(makeZeroWidthPenalty(0));
+                    if (this.lineStartBAP != 0 || this.lineEndBAP != 0) {
+                        baseList.add(new KnuthGlue(this.lineEndBAP, 0, 0,
+                                this.auxiliaryPosition, false));
+                        baseList.add(this.makeZeroWidthPenalty(0));
                         baseList.add(new KnuthGlue(
-                                ai.areaIPD.opt - (lineStartBAP + lineEndBAP),
+                                ai.areaIPD.opt - (this.lineStartBAP + this.lineEndBAP),
                                 ai.areaIPD.max - ai.areaIPD.opt,
                                 ai.areaIPD.opt - ai.areaIPD.min,
                                 mainPosition, false));
-                        baseList.add(makeAuxiliaryZeroWidthBox());
-                        baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                        baseList.add(new KnuthGlue(lineStartBAP, 0, 0,
-                                auxiliaryPosition, false));
+                        baseList.add(this.makeAuxiliaryZeroWidthBox());
+                        baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                        baseList.add(new KnuthGlue(this.lineStartBAP, 0, 0,
+                                this.auxiliaryPosition, false));
                     } else {
                         baseList.add(new KnuthGlue(ai.areaIPD.opt,
                                 ai.areaIPD.max - ai.areaIPD.opt,
@@ -1165,18 +1179,18 @@
                 default:
                     // last line justified, the other lines unjustified:
                     // use only the space stretch
-                    if (lineStartBAP != 0 || lineEndBAP != 0) {
-                        baseList.add(new KnuthGlue(lineEndBAP, 0, 0,
-                                auxiliaryPosition, false));
-                        baseList.add(makeZeroWidthPenalty(0));
+                    if (this.lineStartBAP != 0 || this.lineEndBAP != 0) {
+                        baseList.add(new KnuthGlue(this.lineEndBAP, 0, 0,
+                                this.auxiliaryPosition, false));
+                        baseList.add(this.makeZeroWidthPenalty(0));
                         baseList.add(new KnuthGlue(
-                                ai.areaIPD.opt - (lineStartBAP + lineEndBAP),
+                                ai.areaIPD.opt - (this.lineStartBAP + this.lineEndBAP),
                                 ai.areaIPD.max - ai.areaIPD.opt,
                                 0, mainPosition, false));
-                        baseList.add(makeAuxiliaryZeroWidthBox());
-                        baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                        baseList.add(new KnuthGlue(lineStartBAP, 0, 0,
-                                auxiliaryPosition, false));
+                        baseList.add(this.makeAuxiliaryZeroWidthBox());
+                        baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                        baseList.add(new KnuthGlue(this.lineStartBAP, 0, 0,
+                                this.auxiliaryPosition, false));
                     } else {
                         baseList.add(new KnuthGlue(ai.areaIPD.opt,
                                 ai.areaIPD.max - ai.areaIPD.opt, 0,
@@ -1187,18 +1201,18 @@
         }
     }
 
-    private void addElementsForAWordFragment(List baseList,
-                                             int alignment,
-                                             AreaInfo ai,
-                                             int leafValue,
-                                             MinOptMax letterSpaceWidth) {
+    private void addElementsForAWordFragment(final List baseList,
+                                             final int alignment,
+                                             final AreaInfo ai,
+                                             final int leafValue,
+                                             final MinOptMax letterSpaceWidth) {
 
-        LeafPosition mainPosition = new LeafPosition(this, leafValue);
+        final LeafPosition mainPosition = new LeafPosition(this, leafValue);
 
         // if the last character of the word fragment is '-' or '/',
         // the fragment could end a line; in this case, it loses one
         // of its letter spaces;
-        boolean suppressibleLetterSpace = ai.breakOppAfter && !ai.isHyphenated;
+        final boolean suppressibleLetterSpace = ai.breakOppAfter && !ai.isHyphenated;
 
         if (letterSpaceWidth.min == letterSpaceWidth.max) {
             // constant letter spacing
@@ -1206,138 +1220,152 @@
                         suppressibleLetterSpace
                                 ? ai.areaIPD.opt - letterSpaceWidth.opt
                                 : ai.areaIPD.opt,
-                        alignmentContext,
-                        notifyPos(mainPosition), false));
+                        this.alignmentContext,
+                        this.notifyPos(mainPosition), false));
         } else {
             // adjustable letter spacing
-            int unsuppressibleLetterSpaces
+            final int unsuppressibleLetterSpaces
                 = suppressibleLetterSpace ? ai.letterSpaceCount - 1 : ai.letterSpaceCount;
             baseList.add
                 (new KnuthInlineBox(ai.areaIPD.opt
                         - ai.letterSpaceCount * letterSpaceWidth.opt,
-                        alignmentContext,
-                        notifyPos(mainPosition), false));
-            baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
+                        this.alignmentContext,
+                        this.notifyPos(mainPosition), false));
+            baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
             baseList.add
                 (new KnuthGlue(unsuppressibleLetterSpaces * letterSpaceWidth.opt,
                         unsuppressibleLetterSpaces * (letterSpaceWidth.max - letterSpaceWidth.opt),
                         unsuppressibleLetterSpaces * (letterSpaceWidth.opt - letterSpaceWidth.min),
-                        auxiliaryPosition, true));
-            baseList.add(makeAuxiliaryZeroWidthBox());
+                        this.auxiliaryPosition, true));
+            baseList.add(this.makeAuxiliaryZeroWidthBox());
         }
 
         // extra-elements if the word fragment is the end of a syllable,
         // or it ends with a character that can be used as a line break
         if (ai.isHyphenated) {
             MinOptMax widthIfNoBreakOccurs = null;
-            if (ai.breakIndex < textArray.length) {
+            if (ai.breakIndex < this.textArray.length) {
                 //Add in kerning in no-break condition
-                widthIfNoBreakOccurs = letterAdjustArray[ai.breakIndex];
+                widthIfNoBreakOccurs = this.letterAdjustArray[ai.breakIndex];
             }
             //if (ai.breakIndex)
 
             // the word fragment ends at the end of a syllable:
             // if a break occurs the content width increases,
             // otherwise nothing happens
-            addElementsForAHyphen(baseList, alignment, hyphIPD, widthIfNoBreakOccurs, ai.breakOppAfter && ai.isHyphenated);
+            this.addElementsForAHyphen(baseList, alignment, this.hyphIPD,
+                    widthIfNoBreakOccurs, ai.breakOppAfter && ai.isHyphenated);
         } else if (suppressibleLetterSpace) {
             // the word fragment ends with a character that acts as a hyphen
             // if a break occurs the width does not increase,
             // otherwise there is one more letter space
-            addElementsForAHyphen(baseList, alignment, 0, letterSpaceWidth, true);
+            this.addElementsForAHyphen(baseList, alignment, 0, letterSpaceWidth, true);
         }
     }
 
     // static final int SOFT_HYPHEN_PENALTY = KnuthPenalty.FLAGGED_PENALTY / 10;
-    static final int SOFT_HYPHEN_PENALTY = 1;
+    private static final int SOFT_HYPHEN_PENALTY = 1;
 
-    private void addElementsForAHyphen(List baseList,
-                                       int alignment,
-                                       int widthIfBreakOccurs,
+    private void addElementsForAHyphen(final List baseList,
+                                       final int alignment,
+                                       final int widthIfBreakOccurs,
                                        MinOptMax widthIfNoBreakOccurs,
-                                       boolean unflagged) {
+                                       final boolean unflagged) {
         if (widthIfNoBreakOccurs == null) {
-            widthIfNoBreakOccurs = ZERO_MINOPTMAX;
+            widthIfNoBreakOccurs = TextLayoutManager.ZERO_MINOPTMAX;
         }
 
         switch (alignment) {
         case EN_CENTER :
             // centered text:
-            baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-            baseList.add(new KnuthGlue(lineEndBAP, 3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                               auxiliaryPosition, true));
-            baseList.add(new KnuthPenalty(hyphIPD,
-                        unflagged ? SOFT_HYPHEN_PENALTY : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
-                        auxiliaryPosition, false));
-            baseList.add(new KnuthGlue(-(lineEndBAP + lineStartBAP),
-                        -6 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                        auxiliaryPosition, false));
-            baseList.add(makeAuxiliaryZeroWidthBox());
-            baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-            baseList.add(new KnuthGlue(lineStartBAP, 3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                               auxiliaryPosition, true));
+            baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+            baseList.add(new KnuthGlue(this.lineEndBAP,
+                    3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
+                    this.auxiliaryPosition, true));
+            baseList.add(new KnuthPenalty(this.hyphIPD,
+                    unflagged ? TextLayoutManager.SOFT_HYPHEN_PENALTY
+                            : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
+                    this.auxiliaryPosition, false));
+            baseList.add(new KnuthGlue(-(this.lineEndBAP + this.lineStartBAP),
+                    -6 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
+                    this.auxiliaryPosition, false));
+            baseList.add(this.makeAuxiliaryZeroWidthBox());
+            baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+            baseList.add(new KnuthGlue(this.lineStartBAP,
+                    3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
+                    this.auxiliaryPosition, true));
             break;
 
         case EN_START  : // fall through
         case EN_END    :
             // left- or right-aligned text:
-            if (lineStartBAP != 0 || lineEndBAP != 0) {
-                baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                baseList.add(new KnuthGlue(lineEndBAP, 3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                                   auxiliaryPosition, false));
+            if (this.lineStartBAP != 0 || this.lineEndBAP != 0) {
+                baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                baseList.add(new KnuthGlue(this.lineEndBAP,
+                        3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
+                        this.auxiliaryPosition, false));
                 baseList.add(new KnuthPenalty(widthIfBreakOccurs,
-                            unflagged ? SOFT_HYPHEN_PENALTY : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
-                            auxiliaryPosition, false));
-                baseList.add(new KnuthGlue(widthIfNoBreakOccurs.opt - (lineStartBAP + lineEndBAP),
-                                   -3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                                   auxiliaryPosition, false));
-                baseList.add(makeAuxiliaryZeroWidthBox());
-                baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                baseList.add(new KnuthGlue(lineStartBAP, 0, 0,
-                                   auxiliaryPosition, false));
+                        unflagged ? TextLayoutManager.SOFT_HYPHEN_PENALTY
+                                : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
+                        this.auxiliaryPosition, false));
+                baseList.add(new KnuthGlue(widthIfNoBreakOccurs.opt
+                        - (this.lineStartBAP + this.lineEndBAP), -3
+                        * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
+                        this.auxiliaryPosition, false));
+                baseList.add(this.makeAuxiliaryZeroWidthBox());
+                baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                baseList.add(new KnuthGlue(this.lineStartBAP, 0, 0,
+                                   this.auxiliaryPosition, false));
             } else {
-                baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
+                baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
                 baseList.add(new KnuthGlue(0, 3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
+                            this.auxiliaryPosition, false));
                 baseList.add(new KnuthPenalty(widthIfBreakOccurs,
-                            unflagged ? SOFT_HYPHEN_PENALTY : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
-                            auxiliaryPosition, false));
+                        unflagged ? TextLayoutManager.SOFT_HYPHEN_PENALTY
+                                : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
+                        this.auxiliaryPosition, false));
                 baseList.add(new KnuthGlue(widthIfNoBreakOccurs.opt,
                             -3 * LineLayoutManager.DEFAULT_SPACE_WIDTH, 0,
-                            auxiliaryPosition, false));
+                            this.auxiliaryPosition, false));
             }
             break;
 
         default:
             // justified text, or last line justified:
             // just a flagged penalty
-            if (lineStartBAP != 0 || lineEndBAP != 0) {
-                baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                baseList.add(new KnuthGlue(lineEndBAP, 0, 0,
-                                   auxiliaryPosition, false));
+            if (this.lineStartBAP != 0 || this.lineEndBAP != 0) {
+                baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                baseList.add(new KnuthGlue(this.lineEndBAP, 0, 0,
+                                   this.auxiliaryPosition, false));
                 baseList.add(new KnuthPenalty(widthIfBreakOccurs,
-                            unflagged ? SOFT_HYPHEN_PENALTY : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
-                            auxiliaryPosition, false));
+                        unflagged ? TextLayoutManager.SOFT_HYPHEN_PENALTY
+                                : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
+                        this.auxiliaryPosition, false));
                 // extra elements representing a letter space that is suppressed
                 // if a break occurs
                 if (widthIfNoBreakOccurs.min != 0
                     || widthIfNoBreakOccurs.max != 0) {
-                    baseList.add(new KnuthGlue(widthIfNoBreakOccurs.opt - (lineStartBAP + lineEndBAP),
-                                widthIfNoBreakOccurs.max - widthIfNoBreakOccurs.opt,
-                                widthIfNoBreakOccurs.opt - widthIfNoBreakOccurs.min,
-                                auxiliaryPosition, false));
+                    baseList
+                            .add(new KnuthGlue(widthIfNoBreakOccurs.opt
+                                    - (this.lineStartBAP + this.lineEndBAP),
+                                    widthIfNoBreakOccurs.max
+                                            - widthIfNoBreakOccurs.opt,
+                                    widthIfNoBreakOccurs.opt
+                                            - widthIfNoBreakOccurs.min,
+                                    this.auxiliaryPosition, false));
                 } else {
-                    baseList.add(new KnuthGlue(-(lineStartBAP + lineEndBAP), 0, 0,
-                                       auxiliaryPosition, false));
+                    baseList.add(new KnuthGlue(-(this.lineStartBAP + this.lineEndBAP), 0, 0,
+                                       this.auxiliaryPosition, false));
                 }
-                baseList.add(makeAuxiliaryZeroWidthBox());
-                baseList.add(makeZeroWidthPenalty(KnuthPenalty.INFINITE));
-                baseList.add(new KnuthGlue(lineStartBAP, 0, 0,
-                                   auxiliaryPosition, false));
+                baseList.add(this.makeAuxiliaryZeroWidthBox());
+                baseList.add(this.makeZeroWidthPenalty(KnuthElement.INFINITE));
+                baseList.add(new KnuthGlue(this.lineStartBAP, 0, 0,
+                                   this.auxiliaryPosition, false));
             } else {
                 baseList.add(new KnuthPenalty(widthIfBreakOccurs,
-                            unflagged ? SOFT_HYPHEN_PENALTY : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
-                            auxiliaryPosition, false));
+                        unflagged ? TextLayoutManager.SOFT_HYPHEN_PENALTY
+                                : KnuthPenalty.FLAGGED_PENALTY, !unflagged,
+                        this.auxiliaryPosition, false));
                 // extra elements representing a letter space that is suppressed
                 // if a break occurs
                 if (widthIfNoBreakOccurs.min != 0
@@ -1345,11 +1373,11 @@
                     baseList.add(new KnuthGlue(widthIfNoBreakOccurs.opt,
                                 widthIfNoBreakOccurs.max - widthIfNoBreakOccurs.opt,
                                 widthIfNoBreakOccurs.opt - widthIfNoBreakOccurs.min,
-                                auxiliaryPosition, false));
+                                this.auxiliaryPosition, false));
                 }
             }
         }
-    
+
     }
 
 }



---------------------------------------------------------------------
To unsubscribe, e-mail: fop-commits-unsubscribe@xmlgraphics.apache.org
For additional commands, e-mail: fop-commits-help@xmlgraphics.apache.org