[GitHub] [trafficserver] ywkaras commented on a change in pull request #6699: Log whether client certs were exchanged in TLS handshake

[GitBox <gi...@apache.org>]

ywkaras commented on a change in pull request #6699:
URL: https://github.com/apache/trafficserver/pull/6699#discussion_r414059248



##########
File path: proxy/logging/LogAccess.cc
##########
@@ -1298,6 +1298,44 @@ LogAccess::marshal_client_sni_server_name(char *buf)
   return len;
 }
 
+/*-------------------------------------------------------------------------
+  -------------------------------------------------------------------------*/
+int
+LogAccess::marshal_client_provided_cert(char *buf)
+{
+  int provided_cert = 0;
+  if (m_http_sm) {
+    auto txn = m_http_sm->get_ua_txn();
+    if (txn) {
+      auto ssn = txn->get_proxy_ssn();
+      if (ssn) {
+        auto ssl = ssn->ssl();
+        if (ssl) {
+          provided_cert = ssl->client_provided_certificate();

Review comment:
       In the past, code similar to this has caused segment violations, due to race conditions between the destruction times of associated objects.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org