You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by wcl14 <gi...@git.apache.org> on 2016/08/25 06:12:24 UTC
[GitHub] incubator-hawq pull request #860: HAWQ-1020. Fix bugs to let feature tests T...
GitHub user wcl14 opened a pull request:
https://github.com/apache/incubator-hawq/pull/860
HAWQ-1020. Fix bugs to let feature tests TestCommonLib.TestHdfsConfig\u2026
\u2026 and TestCommonLib.TestYanConfig run in concourse
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/wcl14/incubator-hawq HAWQ-1020
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/860.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #860
----
commit 1b2e004834ff2f71596ebd892008e6a63a70aaea
Author: Chunling Wang <wa...@126.com>
Date: 2016-08-25T06:11:16Z
HAWQ-1020. Fix bugs to let feature tests TestCommonLib.TestHdfsConfig and TestCommonLib.TestYanConfig run in concourse
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #860: HAWQ-1020. Fix bugs to let feature tests T...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/860#discussion_r76186124
--- Diff: src/test/feature/testlib/test_lib.cpp ---
@@ -64,6 +64,13 @@ TEST_F(TestCommonLib, TestHdfsConfig) {
hc.isConfigKerberos();
hc.isTruncate();
std::string hadoopHome = hc.getHadoopHome();
+ /* chmod 777 $HADOOP_HOME/etc/hadoop/hdfs-site.xml */
--- End diff --
It would be better to comment like:
```
Grant access privilege for hdfs-site.xml
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #860: HAWQ-1020. Fix bugs to let feature tests TestComm...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/860
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #860: HAWQ-1020. Fix bugs to let feature tests TestComm...
Posted by huor <gi...@git.apache.org>.
Github user huor commented on the issue:
https://github.com/apache/incubator-hawq/pull/860
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #860: HAWQ-1020. Fix bugs to let feature tests T...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-hawq/pull/860
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---