You are viewing a plain text version of this content. The canonical link for it is here.
Posted to solr-dev@lucene.apache.org by "Chris Eldredge (JIRA)" <ji...@apache.org> on 2009/06/25 01:08:07 UTC

[jira] Created: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
----------------------------------------------------------------------

                 Key: SOLR-1244
                 URL: https://issues.apache.org/jira/browse/SOLR-1244
             Project: Solr
          Issue Type: Bug
          Components: contrib - DataImportHandler
    Affects Versions: 1.4
         Environment: Any.
            Reporter: Chris Eldredge


When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

Posted by "Chris Eldredge (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Chris Eldredge updated SOLR-1244:
---------------------------------

    Attachment: SOLR-1244.patch

Patch against r788203 including unit tests.

> JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
> ----------------------------------------------------------------------
>
>                 Key: SOLR-1244
>                 URL: https://issues.apache.org/jira/browse/SOLR-1244
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Any.
>            Reporter: Chris Eldredge
>         Attachments: SOLR-1244.patch
>
>
> When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1244:
-----------------------------

    Attachment: SOLR-1244.patch

synced w/ trunk . I shall commit this shortly

> JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
> ----------------------------------------------------------------------
>
>                 Key: SOLR-1244
>                 URL: https://issues.apache.org/jira/browse/SOLR-1244
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Any.
>            Reporter: Chris Eldredge
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1244.patch, SOLR-1244.patch
>
>
> When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul reassigned SOLR-1244:
--------------------------------

    Assignee: Noble Paul

> JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
> ----------------------------------------------------------------------
>
>                 Key: SOLR-1244
>                 URL: https://issues.apache.org/jira/browse/SOLR-1244
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Any.
>            Reporter: Chris Eldredge
>            Assignee: Noble Paul
>         Attachments: SOLR-1244.patch
>
>
> When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul resolved SOLR-1244.
------------------------------

    Resolution: Fixed

committed r788265

> JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
> ----------------------------------------------------------------------
>
>                 Key: SOLR-1244
>                 URL: https://issues.apache.org/jira/browse/SOLR-1244
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Any.
>            Reporter: Chris Eldredge
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1244.patch, SOLR-1244.patch
>
>
> When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/SOLR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1244:
-----------------------------

    Fix Version/s: 1.4

> JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
> ----------------------------------------------------------------------
>
>                 Key: SOLR-1244
>                 URL: https://issues.apache.org/jira/browse/SOLR-1244
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Any.
>            Reporter: Chris Eldredge
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1244.patch
>
>
> When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Issue Comment Edited: (SOLR-1244) JdbcDataSource uses wrong overload of getConnection on JNDI DataSource

Posted by "Noble Paul (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/SOLR-1244?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12723904#action_12723904 ] 

Noble Paul edited comment on SOLR-1244 at 6/24/09 10:31 PM:
------------------------------------------------------------

committed r788265

thanks Chris

      was (Author: noble.paul):
    committed r788265
  
> JdbcDataSource uses wrong overload of getConnection on JNDI DataSource
> ----------------------------------------------------------------------
>
>                 Key: SOLR-1244
>                 URL: https://issues.apache.org/jira/browse/SOLR-1244
>             Project: Solr
>          Issue Type: Bug
>          Components: contrib - DataImportHandler
>    Affects Versions: 1.4
>         Environment: Any.
>            Reporter: Chris Eldredge
>            Assignee: Noble Paul
>             Fix For: 1.4
>
>         Attachments: SOLR-1244.patch, SOLR-1244.patch
>
>
> When configured to use a JDBC DataSource via JNDI, JdbcDataSource checks to see if initProps contains a property named "user."  If that property is null, DataSource.getConnection(String user, String password) is used where DataSource.getConnection() should be called.  I will provide a test case and patch that fixes the issue.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.