You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Meng Zhu <mz...@mesosphere.io> on 2019/05/13 14:23:41 UTC
Review Request 70633: Avoided logging quota headroom info when there
is no quota set.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70633/
-----------------------------------------------------------
Review request for mesos and Benjamin Mahler.
Repository: mesos
Description
-------
Avoided logging quota headroom info when there is no quota set.
Diffs
-----
src/master/allocator/mesos/hierarchical.cpp 83b90d5986bcf5ca4a01b17f486f34897462d41a
Diff: https://reviews.apache.org/r/70633/diff/1/
Testing
-------
make check
Thanks,
Meng Zhu
Re: Review Request 70633: Avoided logging quota headroom info when
there is no quota set.
Posted by Benjamin Mahler <bm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/70633/#review215216
-----------------------------------------------------------
Ship it!
Just a thought: It seems like we may want to log a message on every allocation cycle, right now it's VLOG(1). Users or us may wind up using this INFO log message to interpret when allocations are happening, but it might lead to confusion if missing (e.g. one cluster doesn't have non-default quota and the other does).
- Benjamin Mahler
On May 13, 2019, 2:23 p.m., Meng Zhu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/70633/
> -----------------------------------------------------------
>
> (Updated May 13, 2019, 2:23 p.m.)
>
>
> Review request for mesos and Benjamin Mahler.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Avoided logging quota headroom info when there is no quota set.
>
>
> Diffs
> -----
>
> src/master/allocator/mesos/hierarchical.cpp 83b90d5986bcf5ca4a01b17f486f34897462d41a
>
>
> Diff: https://reviews.apache.org/r/70633/diff/1/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Meng Zhu
>
>