[jira] [Commented] (WAGON-487) Saved password with french accent breaks deployment

["Michael Osipov (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/WAGON-487?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16068818#comment-16068818 ] 

Michael Osipov commented on WAGON-487:
--------------------------------------

Basic authentication does not define any transport character encoding. There is no guarantee that your input will arrive the way you want. Use ASCII. This is what HttpClient does by default. I have deployed branch WAGON-487, please close, build and test with your environment. It contains a prototypical, hardcoded value of UTF-8.

> Saved password with french accent breaks deployment
> ---------------------------------------------------
>
>                 Key: WAGON-487
>                 URL: https://issues.apache.org/jira/browse/WAGON-487
>             Project: Maven Wagon
>          Issue Type: New Feature
>          Components: wagon-http
>    Affects Versions: 2.12
>            Reporter: Dominique Jean-Prost
>            Priority: Critical
>
> I cannot deploy any artifact to my sonatype nexus instance when using a pasword with french accetn, like 'é'.
> This instance needs authentication to deploy.
> My test : 
> # Check authentication against nexus directly with a password containing accent : OK
> # Check deploy with clear password in {{settings.xml}} with no accent : OK
> # Check deploy with encrypted password in {{settings.xml}} with no accent : OK
> # Check deploy with clear password in {{settings.xml}} with accent : KO
> # Check deploy with encrypted password in {{settings.xml}} with accent : KO
> After many minutes of debugging, I managed to verify that my password is correctly "read" in the settings {{org.apache.maven.settings.Server}} : it has nothing to do with {{settings.xml}} XML encoding.
> When finally wagon enters the game, the http header with authentication basic contains a '? ' instead of my 'é'. I managed to narrow the problem to {{org.apache.maven.wagon.providers.http.httpclient.impl.auth.BasicScheme}} which I think is the cuplrit by not dealing correctly with charset encoding in the {{authenticate}} method.
> I came to the end of what I can do for the moment, appart of changing my password to remove the accent.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)