You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "elharo (via GitHub)" <gi...@apache.org> on 2023/03/12 18:07:15 UTC

[GitHub] [maven-enforcer] elharo commented on a diff in pull request #253: [MENFORCER-469] Fix banTransitiveDependencies and transitive dependen…

elharo commented on code in PR #253:
URL: https://github.com/apache/maven-enforcer/pull/253#discussion_r1133299571


##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
         this.session = Objects.requireNonNull(session);
     }
 
+    /**
+     * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency

Review Comment:
   I'm not sure what "the result of the transitive dependency" is exactly. Is this just the transitive dependencies of the current maven project? Consider rephrasing.



##########
enforcer-rules/src/main/java/org/apache/maven/enforcer/rules/dependency/ResolveUtil.java:
##########
@@ -66,6 +62,24 @@ class ResolveUtil {
         this.session = Objects.requireNonNull(session);
     }
 
+    /**
+     * Retrieves the {@link DependencyNode} instance containing the result of the transitive dependency
+     * for the current {@link MavenProject} in verbose mode.
+     * <p>
+     * In verbose mode all nodes participating in a conflict are retained.
+     * </p>
+     * <p>
+     * Please consult {@link ConflictResolver} and {@link DependencyManagerUtils}>
+     * /p>

Review Comment:
   `</p>`
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org