You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2022/04/22 11:33:43 UTC

[GitHub] [beam] bullet03 opened a new pull request, #17444: [BEAM-14310] [Website] bug home playground

bullet03 opened a new pull request, #17444:
URL: https://github.com/apache/beam/pull/17444

   [BEAM-14310]
   - add container to iframe
   - add js script to fix bug with scroll of iframe using css prop pointer-event
   - add styles to iframe
   
   ------------------------
   
   Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] [**Choose reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and mention them in a comment (`R: @username`).
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue, if applicable. This will automatically link the pull request to the issue.
    - [ ] Update `CHANGES.md` with noteworthy changes.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
   
   To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
   
   GitHub Actions Tests Status (on master branch)
   ------------------------------------------------------------------------------------------------
   [![Build python source distribution and wheels](https://github.com/apache/beam/workflows/Build%20python%20source%20distribution%20and%20wheels/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
   [![Python tests](https://github.com/apache/beam/workflows/Python%20tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
   [![Java tests](https://github.com/apache/beam/workflows/Java%20Tests/badge.svg?branch=master&event=schedule)](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
   
   See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] dariabezkorovaina commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
dariabezkorovaina commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1111406743

   @pabloem this PR was reviewed by David, can you please help us merge? :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857266022


##########
website/www/site/layouts/index.html:
##########
@@ -71,13 +71,16 @@ <h1>Try Beam Playground</h1>
   <a class="playground__mobile" href="https://play.beam.apache.org/">
     <img src="images/playground.png" alt="beam playground">
   </a>
-  <iframe
-          src="https://play.beam.apache.org/embedded?enabled=true&example=SDK_JAVA/PRECOMPILED_OBJECT_TYPE_EXAMPLE/MinimalWordCount&code="
-          width="100%"
-          height="700px"
-          class="code-snippet playground"
-          allow="clipboard-write">
-  </iframe>
+  <div id="playgroundIframeContainer">
+    <iframe

Review Comment:
   was told to make less commits. before that i made a new one on each logical step. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nausharipov commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
nausharipov commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r856422786


##########
website/www/site/layouts/index.html:
##########
@@ -71,13 +71,16 @@ <h1>Try Beam Playground</h1>
   <a class="playground__mobile" href="https://play.beam.apache.org/">
     <img src="images/playground.png" alt="beam playground">
   </a>
-  <iframe
-          src="https://play.beam.apache.org/embedded?enabled=true&example=SDK_JAVA/PRECOMPILED_OBJECT_TYPE_EXAMPLE/MinimalWordCount&code="
-          width="100%"
-          height="700px"
-          class="code-snippet playground"
-          allow="clipboard-write">
-  </iframe>
+  <div id="playgroundIframeContainer">
+    <iframe

Review Comment:
   Let's format this file. Do it in a separate commit in case other reviewers ask us to revert the change.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nausharipov commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
nausharipov commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r856414390


##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+

Review Comment:
   To avoid future confusion, I suggest to give a more specific name to the file (something like "fix-playground-nested-scroll.js") and add a comment that describes its purpose.
   
   Example of a comment:
   "This script fixes the issue of a sudden scroll interruption when a user's cursor hovered over the embedded playground"



##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+$('#playgroundIframeContainer').on('click', function(event) {

Review Comment:
   'event' is declared but its value is never read.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
pabloem commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1112511427

   thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857266238


##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+

Review Comment:
   got it. gonna fix in future commits. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857299239


##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+$('#playgroundIframeContainer').on('click', function(event) {

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nausharipov commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
nausharipov commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857320697


##########
website/www/site/layouts/index.html:
##########
@@ -71,13 +71,16 @@ <h1>Try Beam Playground</h1>
   <a class="playground__mobile" href="https://play.beam.apache.org/">
     <img src="images/playground.png" alt="beam playground">
   </a>
-  <iframe
-          src="https://play.beam.apache.org/embedded?enabled=true&example=SDK_JAVA/PRECOMPILED_OBJECT_TYPE_EXAMPLE/MinimalWordCount&code="
-          width="100%"
-          height="700px"
-          class="code-snippet playground"
-          allow="clipboard-write">
-  </iframe>
+  <div id="playgroundIframeContainer">
+    <iframe

Review Comment:
   @bullet03 in this case it would make sense to commit the formatted code separately



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1106425572

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1106425569

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nausharipov commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
nausharipov commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857316602


##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+$('#playgroundIframeContainer').on('click', function(event) {

Review Comment:
   @bullet03 I think it's better to use underscore for unused params:
   
   `$('#playgroundIframeContainer').on('click', function(_) {`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
bullet03 commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857390613


##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+
+$('#playgroundIframeContainer').on('click', function(event) {

Review Comment:
   changed



##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+

Review Comment:
   changed



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] asf-ci commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
asf-ci commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1106425566

   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] pabloem merged pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
pabloem merged PR #17444:
URL: https://github.com/apache/beam/pull/17444


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] bullet03 commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
bullet03 commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1106425772

   R: @[nausharipov](https://github.com/nausharipov)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] nausharipov commented on a diff in pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
nausharipov commented on code in PR #17444:
URL: https://github.com/apache/beam/pull/17444#discussion_r857318177


##########
website/www/site/assets/js/fix-playground.js:
##########
@@ -0,0 +1,19 @@
+// Licensed under the Apache License, Version 2.0 (the 'License'); you may not
+// use this file except in compliance with the License. You may obtain a copy of
+// the License at
+//
+//   http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an 'AS IS' BASIS, WITHOUT
+// WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the
+// License for the specific language governing permissions and limitations under
+// the License.
+

Review Comment:
   @bullet03 why future?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [beam] dariabezkorovaina commented on pull request #17444: [BEAM-14310] [Website] bug home playground

Posted by GitBox <gi...@apache.org>.
dariabezkorovaina commented on PR #17444:
URL: https://github.com/apache/beam/pull/17444#issuecomment-1110210076

   @pcoet this is a fix for scrolling issue - the scrolling was "stuck" when on Playground section, can you please review? :) 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@beam.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org