You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Steve Carlin (Code Review)" <ge...@cloudera.org> on 2024/10/21 23:37:21 UTC
[Impala-ASF-CR] IMPALA-13468: Fix various aggregation issues in aggregation.test
Steve Carlin has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/21961 )
Change subject: IMPALA-13468: Fix various aggregation issues in aggregation.test
......................................................................
IMPALA-13468: Fix various aggregation issues in aggregation.test
Various small issues fixed including:
- There is a special operator dedicated to scalar functions not handled in
Calcite. The special agg operator equivalent was created (ImpalaAggOperator)
- Grouping_id function needs to be handled in a special way, calling
AggregateFunction.createRewrittenFunction
- A custom Avg operator was created to handle avg(TIMESTAMP) which isn't allowed
in Calcite.
- A custom Min/Max operator was created to handle min(NULL) and min(char types).
- The corr, covar_pop, and covar_samp functions use the default Impala function
resolver rather than the Calcite resolver.
Change-Id: I038127d6a2f228ae8d263e983b1906e99ae05f77
---
M java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/FunctionResolver.java
A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/CommonOperatorFunctions.java
A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAggOperator.java
A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaAvgAggFunction.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaCustomOperatorTable.java
A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaGroupingIdFunction.java
A java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaMinMaxAggFunction.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperator.java
M java/calcite-planner/src/main/java/org/apache/impala/calcite/operators/ImpalaOperatorTable.java
9 files changed, 436 insertions(+), 71 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/61/21961/3
--
To view, visit http://gerrit.cloudera.org:8080/21961
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I038127d6a2f228ae8d263e983b1906e99ae05f77
Gerrit-Change-Number: 21961
Gerrit-PatchSet: 3
Gerrit-Owner: Steve Carlin <sc...@cloudera.com>