You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by aledsage <gi...@git.apache.org> on 2015/06/10 22:45:13 UTC
[GitHub] incubator-brooklyn pull request: Windows support improvements in J...
GitHub user aledsage opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/685
Windows support improvements in JcloudsLocation
- improved support for windows credentials and
for sshHostAndPortOverride
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aledsage/incubator-brooklyn fix/windows-jcloudslocation-improvements
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/685.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #685
----
commit 03c417580d15da846ac2fe5fb1985c9bfb588cf8
Author: Aled Sage <al...@gmail.com>
Date: 2015-06-05T09:38:43Z
Windows support improvements in JcloudsLocation
- improved support for windows credentials and
for sshHostAndPortOverride
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Windows support improvements in J...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/685#issuecomment-111875189
Much has been reviewed and tested by @nakomis - would appreciate more review and testing though.
Merging.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Windows support improvements in J...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/685
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Windows support improvements in J...
Posted by nakomis <gi...@git.apache.org>.
Github user nakomis commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/685#discussion_r32292331
--- Diff: locations/jclouds/src/main/java/brooklyn/location/jclouds/JcloudsLocation.java ---
@@ -1026,7 +1057,33 @@ public void apply(TemplateOptions t, ConfigBag props, Object v) {
} else if (t instanceof SoftLayerTemplateOptions) {
((SoftLayerTemplateOptions)t).userData(Strings.toString(v));
} else {
- LOG.info("ignoring userDataString({}) in VM creation because not supported for cloud/type ({})", v, t.getClass());
+ // Try reflection: userData(String), or guestCustomizationScript(String);
+ // the latter is used by vCloud Director.
+ Class<? extends TemplateOptions> clazz = t.getClass();
+ Method userDataMethod = null;
+ try {
+ userDataMethod = clazz.getMethod("userData", String.class);
+ } catch (SecurityException e) {
+ LOG.info("Problem reflectively inspecting methods of "+t.getClass()+" for setting userData", e);
+ } catch (NoSuchMethodException e) {
+ try {
+ // For vCloud Director
+ userDataMethod = clazz.getMethod("guestCustomizationScript", String.class);
+ } catch (NoSuchMethodException e2) {
+ // expected on various other clouds
+ }
+ }
+ if (userDataMethod != null) {
+ try {
+ userDataMethod.invoke(Strings.toString(v));
--- End diff --
`userDataMethod.invoke(t, Strings.toString(v));`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---