You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by GitBox <gi...@apache.org> on 2020/01/12 05:28:20 UTC

[GitHub] [hadoop] cxorm commented on a change in pull request #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.

cxorm commented on a change in pull request #1640: HADOOP-16637. Fix findbugs warnings in hadoop-cos.
URL: https://github.com/apache/hadoop/pull/1640#discussion_r365558751
 
 

 ##########
 File path: hadoop-cloud-storage-project/hadoop-cos/src/main/java/org/apache/hadoop/fs/cosn/BufferPool.java
 ##########
 @@ -86,10 +85,6 @@ private File createDir(String dirPath) throws IOException {
       } else {
         LOG.debug("buffer dir: {} already exists.", dirPath);
       }
-    } else {
-      throw new IOException("creating buffer dir: " + dir.getAbsolutePath()
-          + "unsuccessfully.");
-    }
 
 Review comment:
   Thanks @aajisaka for the review.
   Yes I would fix it, and ran the test on this issue.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org