[GitHub] mistercrunch commented on issue #875: Support of JOIN statement for queries

[gi...@git.apache.org]

mistercrunch commented on issue #875: Support of JOIN statement for queries
URL: https://github.com/apache/incubator-superset/issues/875#issuecomment-329677976
 
 
   The tricky part is getting the column metadata. In the `Visualize` button flow in SQL Lab, we already know the columns and have an idea of the data types as we have the result set on hand when the button is clicked.
   
   To do this in the "Add Table" flow, we'd have to run a quick query to do this, which may time out or whatever and again we're just guessing the data types based on the result set which isn't ideal.
   
   Seems like it would be much easier to have another flow that would run a `CREATE VIEW` on the user's behalf (assuming the db user in the connection string has the permission to do that), and then just use the view as if it were a table (then it's easy to get the actual data types from the DB). 
   
   Though then we may need some way to allow users to `ALTER VIEW` as well. All of this is kind of a can of worms...
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services